Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build configuration #1667

Merged
merged 3 commits into from Jun 16, 2021
Merged

Fix build configuration #1667

merged 3 commits into from Jun 16, 2021

Conversation

JimBobSquarePants
Copy link
Member

@JimBobSquarePants JimBobSquarePants commented Jun 16, 2021 •
edited

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 馃懏.
  • I have provided test coverage for my change (where applicable)

Description

Fixes a mistake I introduced in #1664

  • Fixes Debug-InnerLoop project configuration build
  • Removes unused x86 and x64 solution platform configuration
  • Fixes tests build warning

@JimBobSquarePants
Copy link
Member Author

Codecov status is not reporting for some reason.
https://codecov.io/github/SixLabors/ImageSharp/commit/4b1dd91847299033e7b4b1445245ff2c49598d6f

I've added relevant info to this topic in their forums.
https://community.codecov.com/t/github-status-not-being-reported/1874/8?u=jimbobsquarepants

@JimBobSquarePants
Copy link
Member Author

I'm gonna push on with this. I've tested everything locally and CI works + it could block others.

@JimBobSquarePants JimBobSquarePants merged commit c3c3895 into master Jun 16, 2021
@JimBobSquarePants JimBobSquarePants deleted the js/fix-build-configuration branch June 16, 2021 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonfirsov antonfirsov Awaiting requested review from antonfirsov

Assignees
No one assigned
Labels
area:build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@JimBobSquarePants