Potential fix for SBA outline incompatibility #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is untested, but might give a general idea of what I was thinking... Player nametags aren't rendered when entity outlines are rendered, and that's because (unlike `RenderPlayerEvent.Pre`) the `RenderLivingEvent.Specials` event is not fired when rendering outlines. I'm not sure if there are gl translate or scaling issues with this modification since I wasn't able to setup my IDE with gradle.
|
See Issue #19. Hopefully this fixes it? Sorry I wasn't able to compile and test. |
Note from DJ: "since levelhead is 1.8/1.12, I also updated the 1.12 part" Signed-off-by: Phoube <11449309+Phoube@users.noreply.github.com>
DJtheRedstoner
approved these changes
May 9, 2021
|
done in 401ad1a since there needed to be changes anyway |
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is untested, but might give a general idea of what I was thinking...
Player nametags aren't rendered when entity outlines are rendered, and that's because (unlike
RenderPlayerEvent.Pre) theRenderLivingEvent.Specialsevent is not fired when rendering outlines.I'm not sure if there are gl translate or scaling issues with this modification since I wasn't able to setup my IDE with gradle (I don't have nexus credentials?).