Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potential fix for SBA outline incompatibility #18

Closed
wants to merge 3 commits into from
Closed

Potential fix for SBA outline incompatibility #18

wants to merge 3 commits into from

Commits on Apr 30, 2021

  1. Potential fix for SBA outline incompatibility 

    This is untested, but might give a general idea of what I was thinking...
Player nametags aren't rendered when entity outlines are rendered, and that's because (unlike `RenderPlayerEvent.Pre`) the `RenderLivingEvent.Specials` event is not fired when rendering outlines.

I'm not sure if there are gl translate or scaling issues with this modification since I wasn't able to setup my IDE with gradle.
    @Phoube
    Phoube committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    b60fa70 View commit details
    Browse the repository at this point in the history

  2. Named something wrong by accident

    @Phoube
    Phoube committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    8255842 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2021

  1. Patch from DJTheRedstoner, who reviewed, modified, and tested. 

    Note from DJ: "since levelhead is 1.8/1.12, I also updated the 1.12 part"

Signed-off-by: Phoube <11449309+Phoube@users.noreply.github.com>
    @Phoube
    Phoube committed May 9, 2021
    Configuration menu
    Copy the full SHA
    492f7f0 View commit details
    Browse the repository at this point in the history