Creds management #53
Creds management #53
Conversation
zhenik
requested review from
claesgill,
pdmthorsrud and
dangernil
and removed request for
claesgill and
pdmthorsrud
dev/vagrant/bootstrap/vault/post/01-create_vault_policy_to_read_secrets.yml
Outdated
Show resolved
Hide resolved
| access_key = "minio" | ||
| secret_key = "minio123" |
There was a problem hiding this comment.
Make a clear separation between box's minio, and the minio module
| access_key = "minio" | |
| secret_key = "minio123" | |
| box_minio_access_key = "minio" | |
| box_minio_secret_key = "minio123" |
There was a problem hiding this comment.
issue is created Skatteetaten/terraform-nomad-minio#87
There was a problem hiding this comment.
It is not necessary, because box's minio creds are hardcoded in hive.hcl, we do not have variables for that ,
artifact {
source = "s3::http://127.0.0.1:9000/dev/tmp/hive_local.tar"
options {
aws_access_key_id = "minioadmin"
aws_access_key_secret = "minioadmin"
}
}There was a problem hiding this comment.
oh, well, just remove it completely then!
There was a problem hiding this comment.
We need a way how to test the newly build image, without pulling from the docker registry.
This functionality uses only with box, but we still need it, if we want to test changes in docker image, before releasing docker image and pushing it to the registry.
There was a problem hiding this comment.
Yeah, I didn't mean remove the artifact stanza, I meant the variables set in the .tf file
There was a problem hiding this comment.
I have provided comments about it, by ur request. I hoped it could be better explained that way https://github.com/fredrikhgrelland/terraform-nomad-hive/blob/issue_44_creds_management/example/standalone-vault-provided-creds/main.tf#L15-L25
Co-authored-by: Claes Gill <claes@claesgill.com>
Co-authored-by: Claes Gill <claes@claesgill.com>
Co-authored-by: Claes Gill <claes@claesgill.com>
Co-authored-by: Claes Gill <claes@claesgill.com>
Co-authored-by: Claes Gill <claes@claesgill.com>
Co-authored-by: Claes Gill <claes@claesgill.com>
Co-authored-by: Claes Gill <claes@claesgill.com>
Co-authored-by: Claes Gill <claes@claesgill.com>
zhenik
dismissed stale reviews from dangernil, pdmthorsrud, and claesgill
via
e2e8d9d
zhenik
force-pushed
the
issue_44_creds_management
branch
from
dc54ff5
to
e2e8d9d
Compare
Closes/fixes/resolves issue(s)?
What was added/changed/fixed?
todo:
Related issue(s)? [Optional]
Others [Optional]
Checklist (after created PR)