generated from SkillsFundingAgency/das-github-template
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSP-1410: GetEmployerRelationships Endpoint #22
Closed
shaun-downey-education
wants to merge
17
commits into
main
from
CSP-1410-Extend-relationships-endpoint
Closed
CSP-1410: GetEmployerRelationships Endpoint #22
shaun-downey-education
wants to merge
17
commits into
main
from
CSP-1410-Extend-relationships-endpoint
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
shaun-downey-education
commented
May 28, 2024
- Added EmployerRelationshipsController with a GetEmployerRelationships endpoint to allow the access of employer relationships by HashedId, Ukprn and account legal entity PublicHasedId.
… arguements when both arguments are supplied.
…ty public hashed id.
PeterDavidWilliams
previously approved these changes
May 28, 2024
…no account scenario when validating parameters.
DevenKShah
reviewed
May 31, 2024
src/SFA.DAS.PR.Api/Controllers/EmployerRelationshipsController.cs
Outdated
Show resolved
Hide resolved
DevenKShah
previously approved these changes
May 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few questions I have, but this looks good.
...mployerRelationships/Queries/GetEmployerRelationships/GetEmployerRelationshipsQueryResult.cs
Show resolved
Hide resolved
...mployerRelationships/Queries/GetEmployerRelationships/GetEmployerRelationshipsQueryResult.cs
Show resolved
Hide resolved
|
Closing this as 1465 made these changes redundant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.