Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSP-1410: GetEmployerRelationships Endpoint #22

Closed
wants to merge 17 commits into from
Closed

CSP-1410: GetEmployerRelationships Endpoint #22

wants to merge 17 commits into from

Conversation

shaun-downey-education
Copy link
Contributor

  • Added EmployerRelationshipsController with a GetEmployerRelationships endpoint to allow the access of employer relationships by HashedId, Ukprn and account legal entity PublicHasedId.

DevenKShah
DevenKShah previously approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@DevenKShah DevenKShah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few questions I have, but this looks good.

src/SFA.DAS.PR.Application/SFA.DAS.PR.Application.csproj Outdated Show resolved Hide resolved
src/SFA.DAS.PR.Data/Repositories/EmployerRelationshipsReadRepository.cs Show resolved Hide resolved
...mployerRelationships/Queries/GetEmployerRelationships/GetEmployerRelationshipsQueryResult.cs Show resolved Hide resolved
...mployerRelationships/Queries/GetEmployerRelationships/GetEmployerRelationshipsQueryResult.cs Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
97.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@DevenKShah
Copy link
Contributor

Closing this as 1465 made these changes redundant.

@DevenKShah DevenKShah closed this Aug 5, 2024
@DevenKShah DevenKShah deleted the CSP-1410-Extend-relationships-endpoint branch August 5, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DevenKShah DevenKShah DevenKShah left review comments

@PeterDavidWilliams PeterDavidWilliams PeterDavidWilliams left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shaun-downey-education @DevenKShah @PeterDavidWilliams