-
-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New features from 1.13 #1385
Comments
I did already have something like this in #751, but yours is much newer and less cluttered with technical stuff/details so I think we can swap to using your list here. Can you just add the new entities as well? Those being Dolphins, Drowned, Phantom, Turtle, Cod, Salmon, Pufferfish, and Tropical Fish. Also on the note of the new entities, as described in dev22g's release there are some entity supertypes. I'm not sure if there's a supertype for zombies (it's not listed there), but if there isn't one it should be added and the new Drowned mobs should be a part of it. There should also be a fish supertype for the four fish mobs that exist now. |
Also, entity swim state API and swim toggle event. Should be supported just like elytra glide states. |
Closed #751 in favor of this now. Setting to high priority as 1.13 is very close. Aliases rework first, then this stuff immediately. |
Opened another branch for immediate "get it running" issue. |
Only thing that was changed in the EnderSignal was the despawn timer. Status effect as in Potion effect? And finally they added isInWater/isSwimming it's been a method in NMS for a long time and very easy to add, I never understood why they never added it. |
@TheLimeGlass I knew that and already added support for the new methods (added in 1.12.2, not 1.13).
|
hey @Nicofisi I was skimming thru the Spigot API and saw a couple more particles for you to add to your list |
I've added them to the post just now, thanks @ShaneBeee , good catch |
* Create ExprCreeperMaxFuseTicks.java * methodExists * Missing Import * Fix RESET
What's the status of work? Just a question. |
What exactly are you wanting to know? And why exactly are you worried about this? There is not ETA and/or timeline for the issues mentioned in this thread. Things will get done when they get done. If you wish to see that checklist get finished, you are more than welcome to do some PRs to contribute to the things that need to get done. |
What's left in this is no longer of high priority. However, these features would still be nice to have. PRs welcome 🎉 EDIT: Probably going to implement the mending feature myself very soon. |
All that's left are entity/block suggestions. Which an addon like Khoryl focuses on because exact entity types have to be determined at runtime, something that's not logical for Skript erroring and requires janky runtime erroring. Potential close on this? |
Closable after #5617, entities are not currently supported in Skript due to runtime limitations. |
I tried to list all the new features in 1.13 that are relevant for Skript
Many new items/blocks
Out of scope of the issue, need to be taken care of in skript-aliases (useful link - here)
New biomes
minecraft:small_end_islands
minecraft:end_midlands
minecraft:end_highlands
minecraft:end_barrens
minecraft:warm_ocean
minecraft:lukewarm_ocean
minecraft:cold_ocean
minecraft:deep_warm_ocean
minecraft:deep_lukewarm_ocean
minecraft:deep_cold_ocean
minecraft:deep_frozen_ocean
minecraft:frozen_ocean
New enchantments
New particles
minecraft:bubble_column_up
minecraft:bubble_pop
minecraft:current_down
minecraft:squid_ink
minecraft:dolphin
minecraft:nautlius
New status effects
New entities
Tags
New things in the Bukkit API
Added after 1.12
Entity.getPistonMoveReaction()
BroadcastMessageEvent extends ServerEvent implements Cancellable
getMessage()
,setMessage(value)
getRecipients()
, sometimes modifiable, sometimes not?PlayerPickupItemEvent
(which Skript uses) deprecated in favor of the newEntityPickupItemEvent
(we should probably support both?)Added after 1.12.2
Creeper
getMaxFuseTicks()I
,setMaxFuseTicks(I)
getExplosionRadius()I
,setExplosionRadius(I)
Score#isScoreSet()Z
although Skript has no scoreboard support at the momentPlayerItemMendEvent extends PlayerEvent implements Cancellable
getPlayer()Player
getItem()ItemStack
getExperienceOrb()ExperienceOrb
getRepairAmount()I
,setRepairAmount(I)
Player#hidePlayer
andPlayer.showPlayer
were interestingly improved - handled by @BlueyescatVillager
getCareer()Career
,setCareer(Career)
setCareer(Career, boolean resetTrades)
- more infoCreatureSpawner
but Skript doesn't have any spawner support afaikAbstractHorse#getInventory()AbstractHorseInventory
probably unimportant thoughEnderSignal
Slime
-getTarget()LivingEntity
,setTarget(LivingEntity)
Arrow
-isInBlock()Z
,getAttachedBlock()Block
- arrows in a block are motionless and may be picked up by playersAdded in 1.13
Entity
-isSwimming()Z
,setSwimming(Z)
EntityToggleSwimEvent extends EntityEvent implements Cancellable
getEntity()Entity
isSwimming()Z
Other (not really related)
time_since_rest
)The text was updated successfully, but these errors were encountered: