Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show right amount of loaded commands after reload #3711

Merged
merged 2 commits into from
Mar 21, 2021
Merged

Show right amount of loaded commands after reload #3711

merged 2 commits into from
Mar 21, 2021

Conversation

TPGamesNL
Copy link
Member

Description

Skript displays the wrong amount of commands (and functions, if that was displayed) when reloading all scripts (or when reloading a specific script with log verbosity 'high'). Example:

command [[[[[[:
	trigger:
		stop
command [[[[[[:
	trigger:
		stop
command [[[[[[:
	trigger:
		stop
command [[[[[[:
	trigger:
		stop
command [[[[[[:
	trigger:
		stop

image

Target Minecraft Versions: any
Requirements: nony
Related Issues: none

WeeskyBDW
WeeskyBDW previously approved these changes Jan 26, 2021
View reviewed changes
@ShaneBeee ShaneBeee changed the base branch from master to dev-2.5 January 30, 2021 06:18
@ShaneBeee ShaneBeee dismissed WeeskyBDW’s stale review January 30, 2021 06:18

The base branch was changed.

@ShaneBeee ShaneBeee added 2.5 bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. labels Jan 30, 2021
ShaneBeee
ShaneBeee previously approved these changes Jan 30, 2021
View reviewed changes
Copy link
Contributor

@ShaneBeee ShaneBeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

APickledWalrus
APickledWalrus previously approved these changes Mar 1, 2021
View reviewed changes
@Wealthyturtle Wealthyturtle changed the base branch from dev-2.5 to master March 21, 2021 00:23
@Wealthyturtle Wealthyturtle dismissed stale reviews from APickledWalrus and ShaneBeee March 21, 2021 00:23

The base branch was changed.

@Wealthyturtle Wealthyturtle merged commit ba41957 into SkriptLang:master Mar 21, 2021
@TPGamesNL TPGamesNL deleted the fix/functions-commands-count branch March 21, 2021 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wealthyturtle Wealthyturtle Wealthyturtle approved these changes

@ShaneBeee ShaneBeee ShaneBeee left review comments

@APickledWalrus APickledWalrus APickledWalrus left review comments

@WeeskyBDW WeeskyBDW WeeskyBDW left review comments

Assignees
No one assigned
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TPGamesNL @Wealthyturtle @ShaneBeee @APickledWalrus @WeeskyBDW