Add support for InventoryClickEvent cursor #5308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheLimeGlass
added
the
enhancement
kiip1
reviewed
Feb 21, 2023
Co-authored-by: Kiip <25848425+kiip1@users.noreply.github.com>
Co-authored-by: Kiip <25848425+kiip1@users.noreply.github.com>
TheLimeGlass
requested review from
Moderocky,
AyhamAl-Ali and
APickledWalrus
and removed request for
kiip1
Moderocky
approved these changes
Jul 12, 2023
kiip1
approved these changes
Jul 22, 2023
Moderocky
force-pushed
the
master
branch
2 times, most recently
from
bd134d0
to
3f08853
Compare
Moderocky
approved these changes
Sep 17, 2023
sovdeeth
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the event is an InventoryClickEvent, it should return the cursor slot involved in the inventory click event.
Note: InventoryClickEvent#setCursor is deprecated as it causes inconsistencies with the client and server, so I believe keeping Player#setItemOnCursor as the main set changer is good.
Target Minecraft Versions: any
Requirements: none
Related Issues: #5050