Add support for grabbing the involved event in SimplePropertyExpression

[TheLimeGlass]

Description

Add support for grabbing the involved event in SimplePropertyExpression. Useful so that you don't have to use PropertyExpression just so that you can grab the event.

[TPGamesNL]

I don't think SimplePropertyExpressions should have access to the Event. If it needs the Event, it should extend PropertyExpression instead. The Simple part of it means it doesn't do that much, including not using the Event.

[TheLimeGlass]

I don't think SimplePropertyExpressions should have access to the Event. If it needs the Event, it should extend PropertyExpression instead. The Simple part of it means it doesn't do that much, including not using the Event.

An example would be in my other pull request, when all I needed was simply the event #5308

[TPGamesNL]

An example would be in my other pull request, when all I needed was simply the event #5308

Yea I think it's fair that that's a PropertyExpression now

[TheLimeGlass]

I don't think SimplePropertyExpressions should have access to the Event. If it needs the Event, it should extend PropertyExpression instead. The Simple part of it means it doesn't do that much, including not using the Event.

I totally see the reasoning behind this, but when it comes to an event specific value like player cursor from an inventory click event; I believe there needs to be support for getting the event.

Your argument makes sense, as we don't want a SimplePropertyExpression to allow multiple expression inputs. That would defeat the whole purpose of SimplePropertyExpression vs PropertyExpression.

A solution I see, is making the init final in the SimplePropertyExpression. That way the implementing class cannot use the event for multiple expression inputs, and with this pull, you'd still be able to get an event for grabbing that value from it.

away, and opinion

[UnderscoreTud]

A solution I see, is making the init final in the SimplePropertyExpression. That way the implementing class cannot use the event for multiple expression inputs, and with this pull, you'd still be able to get an event for grabbing that value from it.

I don't believe it should be made final because you wouldn't be able to use parse tags/marks then.

[TheLimeGlass]

A solution I see, is making the init final in the SimplePropertyExpression. That way the implementing class cannot use the event for multiple expression inputs, and with this pull, you'd still be able to get an event for grabbing that value from it.

I don't believe it should be made final because you wouldn't be able to use parse tags/marks then.

Ya, but you really wouldn't need it for a simple property expression.

Could be passed into a collection field object aswell, that could also involve the event.

[Moderocky]

Are there any pending changes that require this behaviour?

[TheLimeGlass]

Closing as the underlining issue was solved by making isSingle not final for PropertyExpressions and also you should be using an EventValueExpression for event related expressions.