-
-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update passengers and vehicles #5312
base: dev/feature
Are you sure you want to change the base?
Conversation
Co-authored-by: Kiip <25848425+kiip1@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice PR ⚡
Co-authored-by: Ayham Al Ali <20037329+AyhamAl-Ali@users.noreply.github.com>
Tests failing |
closing due to inactivity |
206e21d
to
f6142ee
Compare
Conflicts were rough. Can we please get this merged soon to avoid more conflicts? The current class present on master was importing the org.bukkit.event.entity.EntityMountEvent which was throwing an exception for not existing on older versions. |
Description
Update passengers and vehicles. The version control was missed when we removed everything under 1.13. Multiple passenger support is 1.9 and 1.12 in Spigot for some event.
vehicle
andpassenger[s]
default expressions so you can use them in vehicle events.make ride
entity as that takes another tick. Something we need the JUnit test pull request for to be able to delay.Target Minecraft Versions: any
Requirements: none
Related Issues: non closing isEmpty #4185