Cleanup EnumUtils #5744
Merged
Cleanup EnumUtils #5744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes some validation performed by the class. Notably, validation will only be performed when the language updates, meaning this class no longer supports runtime Enum changes.
APickledWalrus
added
the
enhancement
TheLimeGlass
requested changes
Jul 14, 2023
Moderocky
approved these changes
Aug 5, 2023
Moderocky
force-pushed
the
master
branch
3 times, most recently
from
bd134d0
to
3f08853
Compare
TheLimeGlass
approved these changes
Sep 25, 2023
TheLimeGlass
previously requested changes
Sep 25, 2023
Fusezion
reviewed
Oct 5, 2023
Co-authored-by: Fusezion <fusezionstream@gmail.com>
sovdeeth
approved these changes
Dec 30, 2023
AyhamAl-Ali
approved these changes
Dec 30, 2023
sovdeeth
added
the
feature-ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates EnumUtils with better method names and javadoc. I've also addressed the issue reported in #5743 by cutting down on the validation performed. In its current state, it's rather excessive as it tries to handle runtime changes to enum changes via reflection. I likely broke this during my PR to add gender support to this class. However, I have opted to remove these checks completely as I don't feel it's necessary for us to support it in any way. Modifying enums during runtime is risky and unlikely to take place anyways. If you think we should handle this, I am happy to discuss it.
I have also opted to change the "Missing entry" from a warning to a debug message (similar to the "generating temporary alias" message). This message does not need to be displayed for he average user. Also, it can repeat multiple times if the language change listeners activate, like when another addon loads a language (see screenshot below).
Target Minecraft Versions:
Requirements:
Related Issues: