Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing enum error can be displayed twice or thrice #5743

Closed
1 task done
TheLimeGlass opened this issue Jun 16, 2023 · 1 comment
Closed
1 task done

Missing enum error can be displayed twice or thrice #5743

TheLimeGlass opened this issue Jun 16, 2023 · 1 comment
Assignees
@APickledWalrus
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements).

Comments

@TheLimeGlass
Copy link
Collaborator

TheLimeGlass commented Jun 16, 2023 •
edited
Loading

Skript/Server Version

2.7.0-beta3
1.20 Paper

Bug Description

When missing an enum from the default.lang, an error will be displayed that it is missing, but that error can sometimes be printed up to two or even three times consecutively.

Expected Behavior

This should not be the case, the error should only print once for each missing enum, no duplicates. There is most likely a for loop that is not being continued or returned when the error happens.

Steps to Reproduce

Remove an enum value from the default.lang

Errors or Screenshots

See #5740 for how it gets printed.

Other

No response

Agreement

  • I have read the guidelines above and affirm I am following them with this report.
@TheLimeGlass TheLimeGlass added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements). labels Jun 16, 2023
@APickledWalrus
Copy link
Member

This is an issue with the EnumUtils validation. I probably broke it during my one PR that added gender support. I'll assign this issue to myself and have a PR fix soon :)

@APickledWalrus APickledWalrus self-assigned this Jun 16, 2023
@APickledWalrus APickledWalrus mentioned this issue Jun 19, 2023
Merged
@APickledWalrus APickledWalrus added the PR available Issues which have a yet-to-be merged PR resolving it label Jun 19, 2023
@sovdeeth sovdeeth added completed The issue has been fully resolved and the change will be in the next Skript update. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. and removed PR available Issues which have a yet-to-be merged PR resolving it labels Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@APickledWalrus APickledWalrus

Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sovdeeth @TheLimeGlass @APickledWalrus