Remove FishData #6752
Merged
Remove FishData #6752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sovdeeth
added
the
bug
Fusezion
reviewed
Jun 1, 2024
APickledWalrus
approved these changes
Jun 1, 2024
Moderocky
requested changes
Jun 1, 2024
look at it now, nerd |
Moderocky
approved these changes
Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
FishData was a bit of a black sheep in the family, where it was in charge of handling multiple classes instead of just one class with variants. It also didn't work at all. This PR removes it, replacing it with a supertype data. This means all the spawning is now part of the already-registered simple datas (or TropicalFishData), which all work. It maintains the comparability of fish, but means that you can't spawn a random fish with
spawn a fish. Given that this was broken prior to this PR, I don't think it's much of an issue. It also follows the same behavior asspawn a mob.Target Minecraft Versions: any
Requirements: none
Related Issues: #6707