Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove FishData #6752

Merged
merged 3 commits into from
Jun 1, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
149 changes: 0 additions & 149 deletions src/main/java/ch/njol/skript/entity/FishData.java

This file was deleted.

1 change: 1 addition & 0 deletions src/main/java/ch/njol/skript/entity/SimpleEntityData.java
Original file line number Diff line number Diff line change
Expand Up @@ -336,6 +336,7 @@ private static void addSuperEntity(String codeName, Class<? extends Entity> enti
addSuperEntity("mob", Mob.class);
addSuperEntity("creature", Creature.class);
addSuperEntity("animal", Animals.class);
addSuperEntity("fish", Fish.class);
addSuperEntity("golem", Golem.class);
addSuperEntity("projectile", Projectile.class);
addSuperEntity("living entity", LivingEntity.class);
Expand Down
26 changes: 26 additions & 0 deletions src/test/skript/tests/regressions/6707-spawn-fish-types.sk
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
test "spawn fish types":
spawn a cod at spawn of world "world":
set {_e} to entity
assert {_e} is a cod with "failed to spawn a cod"
delete entity within {_e}

spawn a salmon at spawn of world "world":
set {_e} to entity
assert {_e} is a salmon with "failed to spawn a salmon"
delete entity within {_e}

spawn a puffer fish at spawn of world "world":
set {_e} to entity
assert {_e} is a puffer fish with "failed to spawn a puffer fish"
delete entity within {_e}

spawn a tropical fish at spawn of world "world":
set {_e} to entity
assert {_e} is a tropical fish with "failed to spawn a tropical fish"
delete entity within {_e}

parse if running minecraft "1.19":
spawn a tadpole at spawn of world "world":
set {_e} to entity
assert {_e} is a tadpole with "failed to spawn a tadpole"
delete entity within {_e}
sovdeeth marked this conversation as resolved.
Show resolved Hide resolved