add grpc skywalking #236
Merged
add grpc skywalking #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good job !! |
ShaoHans
added a commit
to ShaoHans/SkyAPM-dotnet
that referenced
this pull request
Sep 11, 2019
add grpc skywalking (SkyAPM#236)
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.由于Grpc没有Diagnostics机制，只能通过它本身提供的Interceptor拦截器去实现追踪，因此貌似没有办法做到代码无浸入，必须要注入该追踪拦截器
2.Grpc客户端需要在new Channel().Intercept()中传入ClientDiagnosticInterceptor实例对象
3.Grpc服务端需要在start()服务之前传入ServerDiagnosticInterceptor实例对象
详情可以参考示例代码，效果截图