Allows to modify the start time and end time properties of the SegmentSpan object.

[qq362220083]

Why submit this pull request?

• Bug fix
• New feature provided
• Improve performance

---

New feature

• Allows to modify the start time and end time properties of the SegmentSpan object.

  In a specific scenario, I want to modify the start time and end time properties of the SegmentSpan object.
  For example, in the diagnostic information of StackExchange.Redis(SERedis), the start time and end time are determined by SERedis

[wu-sheng]

Why and when would you need to change manually? This is not a typical feature for SkyWalking.

[wu-sheng]

For example, in the diagnostic information of StackExchange.Redis(SERedis), the start time and end time are determined by SERedis

I have read this, but it is not clear.

[qq362220083]

The collection method of SERedis is to collect all commands and time objects under the current link at one time.

like this: https://github.com/StackExchange/StackExchange.Redis/blob/main/src/StackExchange.Redis/Profiling/ProfiledCommandEnumerable.cs

it contains the exact time of the beginning and end of the event, so I hope to modify the time of the SegmentSpan object.

[wu-sheng]

@liuhaoyang Your call. This seems very language related.

[qq362220083]

I tried to implement the ISegmentContextFactory interface, but still cannot modify the SegmentContext and SegmentSpan object properties.

[liuhaoyang]

My suggestion is that you add StartTime to the API of ISegmentContextFactory and modify the Finish function of SegmentSpan to pass in the EndtTime parameter.

public interface ISegmentContextFactory
{
   SegmentContext CreateEntrySegment(string operationName, ICarrier carrier,long stratTime = default(...));
   ...
}
public class SegmentSpan 
{
 ...
  public void Finish(long endTime = default(...))
  {
    ...
  }
}

[qq362220083]

My suggestion is that you add StartTime to the API of ISegmentContextFactory and modify the Finish function of SegmentSpan to pass in the EndtTime parameter.

public interface ISegmentContextFactory
{
   SegmentContext CreateEntrySegment(string operationName, ICarrier carrier,long stratTime = default(...));
   ...
}
public class SegmentSpan 
{
 ...
  public void Finish(long endTime = default(...))
  {
    ...
  }
}

Okay, I have modified and commit it as suggested.