Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetch the latest protocol commit #463

Merged
merged 4 commits into from
Feb 1, 2022
Merged

Conversation

liuhaoyang
Copy link
Collaborator

@liuhaoyang liuhaoyang commented Feb 1, 2022

Please answer these questions before submitting pull request
fetch the latest protocol commit

@wu-sheng
Copy link
Member

wu-sheng commented Feb 1, 2022

So, we removed the support for previous protocol? I remember we have v6 and v8 supports right now, right?

@wu-sheng wu-sheng added this to the 2.0.0 milestone Feb 1, 2022
@liuhaoyang
Copy link
Collaborator Author

I found out that v6 is no longer supported #314, I just removed the build configuration that didn't need

@wu-sheng
Copy link
Member

wu-sheng commented Feb 1, 2022

I see, then it is reasonable to remove. I have known a lot of users set this config wrong(sw6), and were confused.

@wu-sheng wu-sheng added the dependencies Pull requests that update a dependency file label Feb 1, 2022
@wu-sheng
Copy link
Member

wu-sheng commented Feb 1, 2022

Notice, the roamap.md and link in the readme should be updated.

@liuhaoyang
Copy link
Collaborator Author

Notice, the roamap.md and link in the readme should be updated.

I will update them later in other pr, let me think about what features to do next ...

@wu-sheng
Copy link
Member

wu-sheng commented Feb 1, 2022

Notice, the roamap.md and link in the readme should be updated.

I will update them later in other pr, let me think about what features to do next ...

Sure, it is fine to remove them. We don't maintain any roadmap even for the main repo :) Things are not predictable.

wu-sheng
wu-sheng previously approved these changes Feb 1, 2022
@wu-sheng wu-sheng merged commit 85e05cd into SkyAPM:master Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants