Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change log message format. #548

Merged
merged 1 commit into from Mar 9, 2023
Merged

Change log message format. #548

merged 1 commit into from Mar 9, 2023

Conversation

inversionhourglass
Copy link
Contributor

Please answer these questions before submitting pull request

Bug fix

  • Bug description.

  • How to fix?

New feature or improvement

  • Describe the details and related test reports.

@liuhaoyang
Copy link
Collaborator

Is there any change in the display of logs in the UI ?

@inversionhourglass
Copy link
Contributor Author

  • Before this, Endpoint is always empty on UI, now it shows entry span operation name if exists.
  • Before this, Tags is always empyu on UI, now it shows logger(logger class name), level(logger level), thread(current thread id) and errorType(exception type if has an exception).
  • Before this, Content contains className(renamed to logger, same as java), level and logMessage, now it only contains logMessage value.

@wu-sheng wu-sheng requested a review from liuhaoyang March 9, 2023 11:31
@wu-sheng wu-sheng added this to the 2.2.0 milestone Mar 9, 2023
@wu-sheng wu-sheng added the enhancement New feature or request label Mar 9, 2023
liuhaoyang
liuhaoyang approved these changes Mar 9, 2023
View reviewed changes
Copy link
Collaborator

@liuhaoyang liuhaoyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liuhaoyang liuhaoyang merged commit 466754f into SkyAPM:main Mar 9, 2023
1 check passed
@saber-wang saber-wang mentioned this pull request Mar 21, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liuhaoyang liuhaoyang liuhaoyang approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@inversionhourglass @liuhaoyang @wu-sheng