feat: add dubbo-go plugins #34

royal-dargon · 2021-09-30T04:39:54Z

Add dubbo-go plugins.
Add test files.

dubbo-go/dubbo-go.go

.github/workflows/plugin_test.yaml

dubbo-go/test/client/cmd/client.go

…gins into dubbo-go

dubbo-go/test/dubbo_go_plugin_test.yaml

dubbo-go/test/docker-compose.yml

dubbo-go/dubbo-go.go

dubbo-go/test/client/cmd/client.go

Co-authored-by: zhang-wei <zhangwei24@apache.org>

…gins into dubbo-go

arugal · 2021-10-01T00:59:01Z

dubbo-go/README.md

+    log.Fatalf("set tracer error: %v \n", err)
+}
+// set extra tags and report tags
+dubbo_go.SetClientExtraTags("extra-tags", "server")


@royal-dargon The server should use SetServerExtraTags and SetServerReportTags, right?

arugal · 2021-10-01T01:39:37Z

@royal-dargon Please add dubbo-go here.

arugal

@royal-dargon Basically no problem, please commit suggestions, and set PR to ready review.

dubbo-go/README.md

dubbo-go/dubbo-go.go

arugal · 2021-10-01T15:17:18Z

After PR merged, the component id and Component-Server-Mappings of dubbo-go need to be added in component-libraries.yml.

Co-authored-by: zhang-wei <zhangwei24@apache.org>

wu-sheng · 2021-10-02T01:35:47Z

After PR merged, the component id and Component-Server-Mappings of dubbo-go need to be added in component-libraries.yml.

As dubbo-go belongs to dubbo, how about using Dubbo's component id?

wu-sheng · 2021-10-02T09:03:32Z

dubbo-go/test/expected.data.yml

+  {{- range .segmentItems }}
+    {{- if eq .serviceName "dubbo-go-server" }}


Notice, take a look at this context, apache/skywalking#7849 (comment).

range should not be used in the expected file.

@arugal You also should update the existing cases.

wu-sheng · 2021-10-02T09:05:48Z

dubbo-go/dubbo-go.go

+	componentIDGo2SkyClient = 5013
+	componentIDGo2SkyServer = 5014


Take a look at this, https://github.com/apache/skywalking/blob/ebd040eb1a3ed92e79da6f917cb9c9fe44a6938d/oap-server/server-starter/src/main/resources/component-libraries.yml#L41-L43.

You don't need client and server, also, you don't need new component IDs. You could update languages field in the YAML of main repo.

Mapping is for indicating a server side which is not tracing. Such as MySQL JDBC driver to MySQL server. For MySQL server, we don't expect an agent installed.

dubbo-go/test/client/cmd/client.go

dubbo-go/test/docker-compose.yml

dubbo-go/test/dubbo_go_plugin_test.yaml

dubbo-go/test/expected.data.yml

dubbo-go/dubbo-go.go

arugal

LGTM

royal-dargon added 2 commits September 30, 2021 12:30

feat: add dubbo-go plugins

b8a8f3f

fix: fix mockoap address

dcc94d8

arugal self-requested a review September 30, 2021 04:46

arugal added the plugin label Sep 30, 2021

arugal added this to the 1.3.0 milestone Sep 30, 2021

royal-dargon added 3 commits September 30, 2021 13:27

add：lisence

1fc65d3

add: add lisence

806b58b

add: test

a283484

arugal reviewed Sep 30, 2021

View reviewed changes

dubbo-go/dubbo-go.go Outdated Show resolved Hide resolved

.github/workflows/plugin_test.yaml Outdated Show resolved Hide resolved

royal-dargon added 5 commits September 30, 2021 16:57

fix: fix the problem of license

861653b

add:add zk healthcheck

a843960

fix:fix client.go

4a25ff3

fix:fix client.go

9cfc8be

fix:fix client.go

7c3cacc

arugal reviewed Sep 30, 2021

View reviewed changes

dubbo-go/test/client/cmd/client.go Show resolved Hide resolved

arugal and others added 3 commits September 30, 2021 18:25

Update dubbo-go/test/client/cmd/client.go

e866095

fix:fix client.go

cc1362e

Merge branch 'dubbo-go' of https://github.com/royal-dargon/go2sky-plu…

b55b618

…gins into dubbo-go

arugal reviewed Sep 30, 2021

View reviewed changes

dubbo-go/test/dubbo_go_plugin_test.yaml Outdated Show resolved Hide resolved

arugal reviewed Sep 30, 2021

View reviewed changes

dubbo-go/test/docker-compose.yml Outdated Show resolved Hide resolved

arugal reviewed Sep 30, 2021

View reviewed changes

dubbo-go/test/docker-compose.yml Outdated Show resolved Hide resolved

arugal reviewed Sep 30, 2021

View reviewed changes

dubbo-go/dubbo-go.go Outdated Show resolved Hide resolved

arugal reviewed Sep 30, 2021

View reviewed changes

dubbo-go/test/client/cmd/client.go Outdated Show resolved Hide resolved

royal-dargon and others added 7 commits September 30, 2021 20:16

Update dubbo-go/test/client/cmd/client.go

b4783d8

Co-authored-by: zhang-wei <zhangwei24@apache.org>

Update dubbo-go/dubbo-go.go

9a6ffaf

Co-authored-by: zhang-wei <zhangwei24@apache.org>

Update dubbo-go/test/docker-compose.yml

a6e59ce

Co-authored-by: zhang-wei <zhangwei24@apache.org>

Update dubbo-go/test/docker-compose.yml

a4d90cf

Co-authored-by: zhang-wei <zhangwei24@apache.org>

Update dubbo-go/test/dubbo_go_plugin_test.yaml

0c5917a

Co-authored-by: zhang-wei <zhangwei24@apache.org>

Merge branch 'dubbo-go' of https://github.com/royal-dargon/go2sky-plu…

af9b99d

…gins into dubbo-go

docs: update README

8190e92

arugal reviewed Oct 1, 2021

View reviewed changes

royal-dargon added 2 commits October 1, 2021 09:11

fix:fix the except.yml

d3bae49

fix: fix readme

f605002

royal-dargon added 3 commits October 1, 2021 09:42

fix: fix the expected.yml

409683f

fix: fix expected.yml

c1ed6d8

add: add dubbo-go

6b2395a

arugal reviewed Oct 1, 2021

View reviewed changes

dubbo-go/README.md Outdated Show resolved Hide resolved

dubbo-go/README.md Outdated Show resolved Hide resolved

dubbo-go/dubbo-go.go Outdated Show resolved Hide resolved

royal-dargon and others added 3 commits October 2, 2021 00:11

Update dubbo-go/README.md

3bbba2e

Co-authored-by: zhang-wei <zhangwei24@apache.org>

Update dubbo-go/README.md

100c5ad

Co-authored-by: zhang-wei <zhangwei24@apache.org>

Update dubbo-go/dubbo-go.go

c3a11ac

Co-authored-by: zhang-wei <zhangwei24@apache.org>

royal-dargon marked this pull request as ready for review October 2, 2021 02:54

wu-sheng reviewed Oct 2, 2021

View reviewed changes

royal-dargon and others added 4 commits October 9, 2021 20:23

fix:fix some problems

9f4a8fc

fix:fix the problem about expected.yml

965fdc9

fix:fix the expected.yml problems

1786097

Merge branch 'master' into dubbo-go

c490da0

arugal reviewed Oct 11, 2021

View reviewed changes

arugal added 5 commits October 11, 2021 11:01

Update dubbo-go/dubbo-go.go

7971a8d

Update dubbo-go/test/client/cmd/client.go

bdec0f4

Update dubbo-go/test/docker-compose.yml

e95a16b

Update dubbo-go/test/dubbo_go_plugin_test.yaml

9500f60

Update dubbo-go/test/expected.data.yml

fce5dcd

arugal reviewed Oct 11, 2021

View reviewed changes

dubbo-go/dubbo-go.go Outdated Show resolved Hide resolved

Update dubbo-go/dubbo-go.go

66133a1

arugal approved these changes Oct 11, 2021

View reviewed changes

wu-sheng merged commit 6562b6c into SkyAPM:master Oct 11, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add dubbo-go plugins #34

feat: add dubbo-go plugins #34

royal-dargon commented Sep 30, 2021

arugal Oct 1, 2021

royal-dargon Oct 1, 2021

arugal commented Oct 1, 2021

arugal left a comment

arugal commented Oct 1, 2021

wu-sheng commented Oct 2, 2021

wu-sheng Oct 2, 2021

wu-sheng Oct 2, 2021

wu-sheng Oct 2, 2021

arugal left a comment

		{{- range .segmentItems }}
		{{- if eq .serviceName "dubbo-go-server" }}

		componentIDGo2SkyClient = 5013
		componentIDGo2SkyServer = 5014

feat: add dubbo-go plugins #34

feat: add dubbo-go plugins #34

Conversation

royal-dargon commented Sep 30, 2021

arugal Oct 1, 2021

Choose a reason for hiding this comment

royal-dargon Oct 1, 2021

Choose a reason for hiding this comment

arugal commented Oct 1, 2021

arugal left a comment

Choose a reason for hiding this comment

arugal commented Oct 1, 2021

wu-sheng commented Oct 2, 2021

wu-sheng Oct 2, 2021

Choose a reason for hiding this comment

wu-sheng Oct 2, 2021

Choose a reason for hiding this comment

wu-sheng Oct 2, 2021

Choose a reason for hiding this comment

arugal left a comment

Choose a reason for hiding this comment