Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio issue #931

Closed
Git-Forked opened this issue Feb 16, 2021 · 10 comments
Closed

Audio issue #931

Git-Forked opened this issue Feb 16, 2021 · 10 comments
Labels
bug incomplete Not enough information to reproduce
Milestone

Comments

@Git-Forked
Copy link

Skytube played first video with audio, but now all other videos have no audio. All volumes on phone are 100%, and volume in app is 100%. Still no audio. Not sure if there is a secret mute button or something that got pressed, but if so it wasn't obvious enough to find it again.

@Git-Forked Git-Forked added the bug label Feb 16, 2021
@gzsombor
Copy link
Member

Unable to reproduce without details.

@gzsombor gzsombor added the incomplete Not enough information to reproduce label Feb 16, 2021
@Git-Forked
Copy link
Author

Let me know which details you would like me to provide and I will attempt to do so to the best of my ability.
The device used is my S3 (with Android 4.1.2).

@Git-Forked
Copy link
Author

Update: I have discovered that not 'ALL' videos are without audio, just many of them. I have found some videos that do play with audio, so I am thinking that perhaps this is an audio codec issue with the app failing to decode certain audio encodings.

@drogga
Copy link
Contributor

drogga commented Feb 19, 2021

@BugReportering if you read my comments here (in both open & closed issues), you will find that I still use v2.975 (Extra) exactly because of this issue, which started when the (3) separate rez. settings were implemented, the app now simply uses for the most part 'Dash' streams (m3u's) with separate audio, instead of MP4's with build-in \ muxed ones, and our bricks can't handle WEBM's, it's simple as that...

Also keep in mind that older vers., like 2.975 can't play 60 FPS or age restricted videos, so you can just forget about those...

@gzsombor
Copy link
Member

gzsombor commented Feb 25, 2021

So, there are a couple of things, which is missing for me:

  • Do you use the Legacy player or the new Default player? (which is the so-called ExoPlayer)
  • Have you downloaded the files, or directly playing from the net?
    The current - new - logic, is if you are using the Default player and you are directly using the net, SkyTube could pick separate video and audio streams. In any other cases, when you downloads the video or use the legacy player directly, it will use a combined audio-video stream. (In theory, it could download the audio/video streams separately, but it's not yet implemented)

@drogga : I tried the app in emulator, with Android 4 (API 14), but without much success. I could fix the crash, which came from RxJava, but I can't fix the crash from ExoPlayer (Even the old ExoPlayer seems to have parts, where it needs newer API level - and the legacy player also complained about video errors. Unfortunately, it's not clear, if it's because of emulator issues Somewhere I read, that the media player does not work always in older Android versions inside the emulator, so I don't know, how could I test playback, and what kind of formats would work at that API level.

@drogga
Copy link
Contributor

drogga commented Feb 26, 2021

So here on API 16 (4.1.2, as I haven't tested the app on older than that, tho I have a device with 4.0.3 {API/SDK 15}) I use the app with the "Default Player" (as the name suggests - it's the one set by default) and I don't use the "Legacy Player (unsupported)" one (which IS the actual ExoPlayer, the other "default" one is a custom "new" one, not a system's native and build-in old "Exo", so don't confuse the two), simply because it doesn't have playback speed control and the "Official YouTube Player" one I can't use because it doesn't launch\open at all here (understandable on why - it relies on the YT's embed player activity). Other than that - I don't seem to have issues with the player itself, the problem is specifically from the streams that the app picks now...

BTW I saw that you bumped the minSDKversion of your fork to 16...

I don't DL, I play directly - Online !

As of YT stream formats that those old bricks CAN natively handle - Only the default regular\normal MP4 {x/h264} and MP3, M4A & AAC for audio. That includes Live Streams, which are streamed as M3U, M3U8 HLS\Dash.
CAN'T handle - WEBM (v/a), Opus (audio) or the other alternative MP4 video streams encoded\with codec AV1, AVC {h/x265 / HEVC - YT doesn't use this one anyways} or whatever else.

BTW - Other than YT (App or Site) nothing can open age restricted channels like "Bud Light", for which you need to login to YT and be over 18\21 to even see the channel's content (uploads\videos), even none of the invidious instances can't open\load those channels, like the one i mentioned, let along NewPipe, SkyTube ot whatever else, tho their content is playable as a separate individual videos...

@gzsombor
Copy link
Member

The latest release have a configuration to control if you want to use the separate video and audio streams, or you want to stick with the older formats, with merged streams. Please try it out.

@gzsombor gzsombor added this to the v2.979 milestone Nov 15, 2021
@drogga
Copy link
Contributor

drogga commented Nov 15, 2021

@gzsombor This response is targeted to the OP right?, not to me, because I'm already using the latest builds that include that option and my other (recent/latest) feedback is based on that.

@gzsombor
Copy link
Member

Yes, that is about the current issue what OP had.

@manilenio
Copy link

The latest release have a configuration to control if you want to use the separate video and audio streams, or you want to stick with the older formats, with merged streams. Please try it out.

Where can I find this configuration? I don't believe I ever saw this setting. I'm having this problem where the video plays but there's no audio. When I play the same video in newpipe, there's audio. I hope somebody can help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug incomplete Not enough information to reproduce
Projects
None yet
Development

No branches or pull requests

4 participants