Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error messages #40

Merged
merged 1 commit into from
Jul 3, 2020
Merged

Improve error messages #40

merged 1 commit into from
Jul 3, 2020

Conversation

Shatur
Copy link
Collaborator

@Shatur Shatur commented Jul 1, 2020

  • Show shortcut in errors.
  • Make errors translatable.

Before:

QHotkey: Failed to register hotkey. Error: BadAccess (attempt to access private resource denied)
QHotkey: Failed to unregister hotkey. Error: BadAccess (attempt to access private resource denied)
QHotkey: Failed to register hotkey. Error: BadAccess (attempt to access private resource denied)
QHotkey: Failed to unregister hotkey. Error: BadAccess (attempt to access private resource denied)
QHotkey: Failed to register hotkey. Error: BadAccess (attempt to access private resource denied)

After:

QHotkey: "Failed to register Ctrl+Alt+E. Error: BadAccess (attempt to access private resource denied)"
QHotkey: "Failed to register Ctrl+Alt+S. Error: BadAccess (attempt to access private resource denied)"
QHotkey: "Failed to register Ctrl+Alt+G. Error: BadAccess (attempt to access private resource denied)"
QHotkey: "Failed to register Ctrl+Alt+F. Error: BadAccess (attempt to access private resource denied)"
QHotkey: "Failed to register Ctrl+Alt+C. Error: BadAccess (attempt to access private resource denied)"

Also users will be less confused (crow-translate/crow-translate#149).

@Shatur
Improve error messages
483e073 
* Show information about shortcut.
* Make errors translatable.
@Skycoder42 Skycoder42 self-assigned this Jul 3, 2020
@Skycoder42 Skycoder42 merged commit 4f76792 into Skycoder42:master Jul 3, 2020
@Shatur Shatur deleted the improve-error-messages branch July 3, 2020 06:50
@Shatur
Copy link
Collaborator Author

Shatur commented Jul 3, 2020 •
edited
Loading

@Skycoder42, could you draft a new minor release with this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skycoder42 Skycoder42 Skycoder42 approved these changes

Assignees

@Skycoder42 Skycoder42

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Shatur @Skycoder42