Read github credentials from git credential helper #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If no `github_oauth` is defined, try to read it from `git credential fill`. Tested with git-credential-manager. Note: we don't provide success/fail feedback currently, so expired tokens won't be invalidated by us. Fixes: Skydio#129
jerry-skydio
approved these changes
Dec 22, 2023
anguslees
commented
Apr 3, 2024
| args.github_oauth = await git_ctx.credential( | ||
| protocol="https", | ||
| host=args.github_url, | ||
| path=f"/{fork_info.owner}/{fork_info.name}.git", |
There was a problem hiding this comment.
The leading "/" here is incorrect btw, and fails for credential helpers that do naive string matching on URL path 😞. It should be just path=f"{fork_info.owner}/{fork_info.name}.git"
There was a problem hiding this comment.
it's been working for me despite this but i guess there's some subtlety about which credential helpers are being used?
jerry-skydio
added a commit
that referenced
this pull request
Apr 3, 2024
The slash is incorrect according to #131 (comment) "The leading "/" here is incorrect btw, and fails for credential helpers that do naive string matching on URL path 😞. It should be just path=f"{fork_info.owner}/{fork_info.name}.git""
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no
github_oauthis defined, try to read it fromgit credential fill.Tested with git-credential-manager.
Note: we don't provide success/fail feedback currently, so expired tokens won't
be invalidated by us.
Fixes: #129