Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

H2 updates and some minor missing pieces. #122

Merged
merged 3 commits into from
Sep 22, 2017
Merged

H2 updates and some minor missing pieces. #122

merged 3 commits into from
Sep 22, 2017

Conversation

chpapa
Copy link
Contributor

@chpapa chpapa commented Sep 21, 2017

Try to fixes #37 finally.

david90
david90 approved these changes Sep 22, 2017
View reviewed changes
Copy link
Contributor

@david90 david90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carmenlau
Copy link
Contributor

Looks good for me, can merge after fixing the spell check error

@chpapa chpapa merged commit 3530d01 into SkygearIO:master Sep 22, 2017
@chpapa chpapa deleted the h2-updates branch September 22, 2017 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david90 david90 david90 approved these changes

@carmenlau carmenlau Awaiting requested review from carmenlau

Assignees

@carmenlau carmenlau

@david90 david90

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check all guides have meaningful h2
3 participants
@chpapa @carmenlau @david90