Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDK not working on IE10 due to "extend Array" using Array.form #66

Closed
bensonby opened this issue Sep 9, 2016 · 0 comments
Closed

SDK not working on IE10 due to "extend Array" using Array.form #66

bensonby opened this issue Sep 9, 2016 · 0 comments
Assignees
@ben181231

Comments

@bensonby
Copy link
Contributor

bensonby commented Sep 9, 2016 •
edited by ben181231
Loading

Console error message:
Unhandled promise rejectionTypeError: Object doesn't support property or method 'from'

Reason

The section about classes in https://babeljs.io/docs/usage/caveats/

The class QueryResult extends Array in lib/query_result.js, and it uses the static method Array.from through QueryResult.from

Possible fix

http://babeljs.io/docs/plugins/transform-proto-to-assign/

Steps to reproduce

Open any website written with skygear JS SDK on IE10. When there is a query, the error message will appear
@ben181231 ben181231 self-assigned this Sep 9, 2016
ben181231 pushed a commit to ben181231/skygear-SDK-JS that referenced this issue Sep 12, 2016
Fix crash on IE 10 when using Array.from
cec86f8 
Ref. SkygearIO#66
@ben181231 ben181231 mentioned this issue Sep 12, 2016
Merged
ben181231 pushed a commit to ben181231/skygear-SDK-JS that referenced this issue Sep 12, 2016
Fix crash on IE 10 when using Array.from
055c364 
Ref. SkygearIO#66
@rickmak rickmak mentioned this issue Sep 13, 2016
Closed
rickmak added a commit that referenced this issue Sep 13, 2016
@rickmak
Fix crash on IE 10 when using Array.from
a885876 
refs #66
@royuen royuen closed this as completed Sep 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ben181231 ben181231

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bensonby @royuen @ben181231