Remove Pylint-related comments

docs/conf.py

@@ -4,8 +4,6 @@
 # list see the documentation:
 # https://www.sphinx-doc.org/en/master/usage/configuration.html
 
-# pylint: skip-file
-
 # -- Path setup --------------------------------------------------------------
 
 # If extensions (or modules to document with autodoc) are in another directory,

src/probequest/cli.py

@@ -132,9 +132,6 @@ def build_cluster(config):
     Build the ProbeQuest cluster.
     """
 
-    # pylint: disable=import-outside-toplevel
-    # pylint: disable=pointless-statement
-
     try:
         if config.fake:
             from .sniffers.fake_probe_request_sniffer import FakeProbeRequestSniffer
@@ -178,8 +175,6 @@ def main():
     Entry point of the command-line tool.
     """
 
-    # pylint: disable=too-many-statements
-
     root_logger, memory_handler, console = set_up_root_logger()
 
     logger = logging.getLogger(__name__)

src/probequest/config.py

@@ -15,8 +15,6 @@ class Config:
     Configuration object.
     """
 
-    # pylint: disable=too-many-instance-attributes
-
     _interface = None
 
     essid_filters = None

src/probequest/probe_request.py

@@ -34,8 +34,6 @@ def s_mac_oui(self):
         The value is cached once computed.
         """
 
-        # pylint: disable=no-member
-
         if self._s_mac_oui is None:
             try:
                 self._s_mac_oui = EUI(self.s_mac).oui.registration().org

src/probequest/sniffers/fake_probe_request_sniffer.py

@@ -8,8 +8,8 @@
 from scapy.layers.dot11 import RadioTap, Dot11, Dot11ProbeReq, Dot11Elt
 from scapy.pipetool import ThreadGenSource
 
-from faker import Faker  # pylint: disable=import-error
-from faker_wifi_essid import WifiESSID  # pylint: disable=import-error
+from faker import Faker
+from faker_wifi_essid import WifiESSID
 
 
 class FakeProbeRequestSniffer(ThreadGenSource):
@@ -23,8 +23,6 @@ class FakeProbeRequestSniffer(ThreadGenSource):
     this last one only accepts lists, sets and tuples.
     """
 
-    # pylint: disable=too-many-ancestors
-
     def __init__(self, period, period2=0, name=None):
         self.logger = logging.getLogger(__name__)
 
@@ -38,7 +36,6 @@ def __init__(self, period, period2=0, name=None):
 
     def generate(self):
         # Fix a false positive about not finding '_wake_up'.
-        # pylint: disable=no-member
 
         while self.RUN:
             # Infinite loop until 'stop()' is called.
@@ -75,8 +72,6 @@ def __next__(self):
         Generator of fake Wi-Fi probe requests.
         """
 
-        # pylint: disable=no-member
-
         if self._should_stop:
             raise StopIteration
 

tests/unit/test_cli.py

@@ -19,8 +19,6 @@ class TestArgParse(unittest.TestCase):
     Tests the argument parser.
     """
 
-    # pylint: disable=too-many-public-methods
-
     output_test_file = "probequest_test_output.txt"
 
     def setUp(self):
@@ -97,8 +95,6 @@ def test_default_values(self):
         values in the configuration namespace.
         """
 
-        # pylint: disable=no-member
-
         with self.assertRaises(SystemExit) as error_code:
             error_output = StringIO()
 
@@ -123,8 +119,6 @@ def test_interface_argument(self):
         Calls the argument parser with the 'interface' argument.
         """
 
-        # pylint: disable=no-member
-
         config = Namespace()
         self.arg_parser.parse_args(
             [
@@ -141,8 +135,6 @@ def test_without_interface_argument(self):
         interface argument.
         """
 
-        # pylint: disable=no-member
-
         with self.assertRaises(SystemExit) as error_code:
             error_output = StringIO()
 
@@ -163,8 +155,6 @@ def test_debug_option(self):
         Calls the argument parser with the '--debug' option.
         """
 
-        # pylint: disable=no-member
-
         config = Namespace()
         self.arg_parser.parse_args(
             [
@@ -182,8 +172,6 @@ def test_fake_option(self):
         Calls the argument parser with the '--fake' option.
         """
 
-        # pylint: disable=no-member
-
         config = Namespace()
         self.arg_parser.parse_args(
             [
@@ -201,8 +189,6 @@ def test_ignore_case_option(self):
         Calls the argument parser with the '--ignore-case' option.
         """
 
-        # pylint: disable=no-member
-
         config = Namespace()
         self.arg_parser.parse_args(
             [
@@ -220,8 +206,6 @@ def test_short_output_option(self):
         Calls the argument parser with the '-o' option.
         """
 
-        # pylint: disable=no-member
-
         config = Namespace()
         self.arg_parser.parse_args(
             [
@@ -241,8 +225,6 @@ def test_long_output_option(self):
         Calls the argument parser with the '--output' option.
         """
 
-        # pylint: disable=no-member
-
         config = Namespace()
         self.arg_parser.parse_args(
             [
@@ -262,8 +244,6 @@ def test_short_essid_option(self):
         Calls the argument parser with the '-e' option.
         """
 
-        # pylint: disable=no-member
-
         config = Namespace()
         self.arg_parser.parse_args(
             [
@@ -285,8 +265,6 @@ def test_long_essid_option(self):
         Calls the argument parser with the '--essid' option.
         """
 
-        # pylint: disable=no-member
-
         config = Namespace()
         self.arg_parser.parse_args(
             [
@@ -308,8 +286,6 @@ def test_short_regex_option(self):
         Calls the argument parser with the '-r' option.
         """
 
-        # pylint: disable=no-member
-
         config = Namespace()
         self.arg_parser.parse_args(
             [
@@ -328,8 +304,6 @@ def test_long_regex_option(self):
         Calls the argument parser with the '--regex' option.
         """
 
-        # pylint: disable=no-member
-
         config = Namespace()
         self.arg_parser.parse_args(
             [
@@ -349,8 +323,6 @@ def test_essid_regex_mutual_exclusivity(self):
         which must fail as they are in the same mutually exclusive group.
         """
 
-        # pylint: disable=no-member
-
         with self.assertRaises(SystemExit) as error_code:
             error_output = StringIO()
 
@@ -374,8 +346,6 @@ def test_exclude_option(self):
         Calls the argument parser with the '--exclude' option.
         """
 
-        # pylint: disable=no-member
-
         config = Namespace()
         self.arg_parser.parse_args(
             [
@@ -402,8 +372,6 @@ def test_short_station_option(self):
         Calls the argument parser with the '-s' option.
         """
 
-        # pylint: disable=no-member
-
         config = Namespace()
         self.arg_parser.parse_args(
             [
@@ -430,8 +398,6 @@ def test_long_station_option(self):
         Calls the argument parser with the '--station' option.
         """
 
-        # pylint: disable=no-member
-
         config = Namespace()
         self.arg_parser.parse_args(
             [
@@ -460,8 +426,6 @@ def test_exclude_station_mutual_exclusivity(self):
         group.
         """
 
-        # pylint: disable=no-member
-
         with self.assertRaises(SystemExit) as error_code:
             error_output = StringIO()
 

tests/unit/test_probe_request.py

@@ -18,8 +18,6 @@ def test_without_parameters(self):
         Initialises a 'ProbeRequest' object without any parameter.
         """
 
-        # pylint: disable=no-value-for-parameter
-
         with self.assertRaises(TypeError):
             _ = ProbeRequest()
 
@@ -28,8 +26,6 @@ def test_with_only_one_parameter(self):
         Initialises a 'ProbeRequest' object with only one parameter.
         """
 
-        # pylint: disable=no-value-for-parameter
-
         timestamp = 1517872027.0
 
         with self.assertRaises(TypeError):
@@ -40,8 +36,6 @@ def test_with_only_two_parameters(self):
         Initialises a 'ProbeRequest' object with only two parameters.
         """
 
-        # pylint: disable=no-value-for-parameter
-
         timestamp = 1517872027.0
         s_mac = "aa:bb:cc:dd:ee:ff"
 
@@ -53,8 +47,6 @@ def test_create_a_probe_request(self):
         Creates a new 'ProbeRequest' with all the required parameters.
         """
 
-        # pylint: disable=no-self-use
-
         timestamp = 1517872027.0
         s_mac = "aa:bb:cc:dd:ee:ff"
         essid = "Test ESSID"

tests/unit/test_probe_request_parser.py

@@ -47,8 +47,6 @@ def test_fuzz_packets(self):
         'ProbeRequestParser.parse()' function.
         """
 
-        # pylint: disable=no-self-use
-
         with self.assertRaises(TypeError):
             for _ in range(0, 1000):
                 packet = RadioTap() / fuzz(Dot11() / Dot11ProbeReq() / Dot11Elt())