Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTL Fix #126

Merged
merged 2 commits into from
Apr 14, 2017
Merged

RTL Fix #126

merged 2 commits into from
Apr 14, 2017

Conversation

Mehrdadmaskull
Copy link

Fix for #109

@bogren
Copy link
Contributor

bogren commented Apr 12, 2017

Hey thanks for the contribution, can you also add a note in CHANGELOG.md under the master section with a reference to the PR, and feel free to reference yourself.

@bogren bogren mentioned this pull request Apr 12, 2017
@Mehrdadmaskull
Copy link
Author

Sorry for the other PR. Everything good now?

@k0nserv
Copy link
Contributor

k0nserv commented Apr 14, 2017

Yeah looks good, thanks a lot @Mehrdadmaskull 😀

@k0nserv k0nserv merged commit 5a5cf8b into Skyscanner:master Apr 14, 2017
@Mehrdadmaskull
Copy link
Author

I just tried using SFLTF in yet another project, but couldn't find the recent changes to the master branch on the latest version installed from Cocoapods.

@Mehrdadmaskull Mehrdadmaskull deleted the rtlfix branch April 18, 2017 20:01
@k0nserv
Copy link
Contributor

k0nserv commented Apr 19, 2017

Hey @Mehrdadmaskull I had not gotten the time to release yet, however I've just done so. Give 3.1.0 a whirl and see if that doesn't work :)

@Mehrdadmaskull
Copy link
Author

Yea @k0nserv, it works now! Thanks for the release

@iamir4g
Copy link

iamir4g commented Dec 27, 2017

hi
my language phone is US but my app language Persian(RTL) how to change text alignment and placeholder?

@k0nserv
Copy link
Contributor

k0nserv commented Dec 28, 2017

@iamir4g You need to have your phone in Persian for RTL to kick in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants