Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modified example and added description about #248

Merged
merged 1 commit into from
Oct 23, 2018
Merged

modified example and added description about #248

merged 1 commit into from
Oct 23, 2018

Conversation

devmjun
Copy link
Contributor

@devmjun devmjun commented Oct 23, 2018

I have modified example for Error state and delegates. When I use SkyFloatingLabelTextField, I think the example isn't proper at README.md

Because when user typing, func textField(_ textField: UITextField, shouldChangeCharactersIn range: NSRange, replacementString string: String) -> Bool method is called but This method's textfield.text bring value that previous value currently entered.

if a user is typing "A", textfield.text is "", if a user is typing "AB", textfield.text is "A". and then if a user is removing "B" of "AB", textfield.text is "AB". so I think that this situation can cause to be confused.

@k0nserv k0nserv merged commit c7e6cd8 into Skyscanner:master Oct 23, 2018
@k0nserv
Copy link
Contributor

k0nserv commented Oct 23, 2018

Thanks @devmjun 👍

@devmjun devmjun deleted the modified-example-for-error-state-and-delegates branch October 23, 2018 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants