Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatibility with swift 2.3 #69

Merged
merged 1 commit into from
Nov 29, 2016
Merged

Compatibility with swift 2.3 #69

merged 1 commit into from
Nov 29, 2016

Conversation

okipol88
Copy link
Contributor

No description provided.

@wolffan wolffan mentioned this pull request Oct 10, 2016
Merged
6 tasks
wolffan
wolffan reviewed Oct 10, 2016
View reviewed changes
Copy link
Contributor

@wolffan wolffan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please bump version on Podspec and Changelog?
I'll tag it on the release section

SkyFloatingLabelTextField/SkyFloatingLabelTextField.xcodeproj/project.pbxproj
@@ -549,6 +557,7 @@
IPHONEOS_DEPLOYMENT_TARGET = 8.0;
MTL_ENABLE_DEBUG_INFO = NO;
SDKROOT = iphoneos;
SWIFT_OPTIMIZATION_LEVEL = "-Owholemodule";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @okipol88 could you explain this one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wolffan
Sorry was absent for some time.
The level is, as what i recall, the suggestion of xCode8 build settings.

@wolffan wolffan merged commit 089339d into Skyscanner:master Nov 29, 2016
@k0nserv
Copy link
Contributor

k0nserv commented Nov 29, 2016

Thanks for the contribution @okipol88 🎉

@k0nserv k0nserv mentioned this pull request Nov 29, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolffan wolffan wolffan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@okipol88 @k0nserv @wolffan