Migrate to Swift 3

[DenTelezhkin]

Hey!

Since we need this framework working for our app, we wanted to help with migration to Swift 3.

What's in this PR?

• Migrated SkyFloatingLabelTextField framework and unit test target to Swift 3 syntax
• Migrated example target to Swift 3
• Verified that all unit tests pass
• Verified that example app functions properly
• Switched to Xcode 8 for running tests on Travis CI
• Added .swift-version file to allow properly linting podspec when you are ready to release

I did not do any Swift API design guidelines-related changes, i thought that as library authors, you would probably want to make those choices yourselves. I would be happy to help with other issues of Swift 3 transition, if they arise.

Thanks for awesome library, and hope this PR will be helpful.

[Al3x4nd3r]

I liked this pull too

[Tibb]

Hi @DenHeadless, could you consider putting your pull request on a public repo? Then we'll be able to integrate it with cocoapods and use it a temporary solution at least. Thanks a lot!

[DenTelezhkin]

@Tibb What do you mean by public repo? It is public, we are using it in CocoaPods, like so:

pod 'SkyFloatingLabelTextField', git: "https://github.com/MLSDev/SkyFloatingLabelTextField.git", branch: "swift3"

[Tibb]

@DenHeadless Well, I might have made a mistake in the path in my podfile when I tried to use your branch... :/ Thanks for the tip, seems to work 👍

[Tibb]

Working great so far. Good job!

[DenTelezhkin]

@gergelyorosz @intonarumori Guys, just pinging you in case you haven't seen this PR. I understand that's an open-source, and you don't owe us anything, but any hint on when this could be merged or not merged would be nice, since already 20 days have passed since PR was opened.

As i've said, we'll be happy to help if any other assistance is needed with Swift 3 migration.

[wolffan]

@DenHeadless Hello! Thanks for this. I haven't had time to look at this.
My plan is though: migrate first the 2.3 PR -> #69

Then do a major version changes for this one.

Not sure I'll have time to do both today. But It's going to happen.
Thanks for your work and patience

[DenTelezhkin]

@wolffan Thanks! No worries, take your time! 🍺

[chungbd]

I've just used this lib for my application, so I really so interested in updating code to Swift 3.0.

@wolffan you met an obstacle, didn't you? Let's know it, may everybody can help you. Thanks

[ctews]

+1

[intonarumori]

+1000

[k0nserv]

Hey @DenHeadless can you rebase this on master?

[DenTelezhkin]

@k0nserv Sure, rebased.

[DenTelezhkin]

Travis failure seems completely unrelated to code changes in PR. Tests pass locally on my machine. iOS CI as always, incredibly stable =)

[k0nserv]

I'll run them locally too, restarted travis as well. Might be a fluke

[k0nserv]

Right tests, pass locally for me as well

[k0nserv]

@bogren might have fixed the travis issue in #76 if you wanna try and rebase again

[DenTelezhkin]

Sure, let's give it a shot =) Rebased once more.

[k0nserv]

That did it, thanks @bogren 👍 Just gotta finish up the work on 2.3 then we can merge this

[bogren]

Awesome! 👏 No problem ☺️

[wolffan]

Merged 2.3!
Can we resolve conflicts :) ?

[DenTelezhkin]

Rebased once more =)

[k0nserv]

Great thank you for all the help @DenHeadless

[k0nserv]

LGTM

[bogren]

Sorry, you have to rebase again 😇

[k0nserv]

We can always rebase ourselves, no need to do it

[DenTelezhkin]

Yep, edits from maintainers is on =) Please just let me know when you are ready to merge, and i can rebase one final time =)

[k0nserv]

Massive thanks for this PR @DenHeadless :)

[DenTelezhkin]

Thank you guys! This is great news! Are you planning 2.0 release for CocoaPods?

[k0nserv]

Yeah, I'm working on that at the moment

[k0nserv]

See #81