Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CAPY-119] Update BpkCalendarGrid selection color to surface-subtle #2982

Merged
merged 6 commits into from
Aug 31, 2023

Conversation

dyhagho
Copy link
Contributor

@dyhagho dyhagho commented Aug 29, 2023

Jira ticket: CAPY-119

Update calendar components to be compliant with figma design. Changes:

  • Change BpkCalendarGrid background colour (from $bpk-surface-highlight-day to $bpk-surface-subtle-day) when selected range of dates.
  • Update BpkCalendarDate background colour (from $bpk-surface-highlight-day to $bpk-surface-subtle-day) for any dates in between the range.

Colour Before

Colour After

Remember to include the following changes:

  • README.md (If you have created a new component)
  • Component README.md
  • Tests
  • Storybook examples created/updated
  • For breaking changes or deprecating components/properties, migration guides added to the description of the PR. If the guide has large changes, consider creating a new Markdown page inside the component's docs folder and link it here

@dyhagho dyhagho changed the title Update BpkCalendarGrid selection color to surface-subtle [CAPY-119] Update BpkCalendarGrid selection color to surface-subtle Aug 29, 2023
@github-actions
Copy link

Visit https://backpack.github.io/storybook-prs/2982 to see this build running in a browser.

@dyhagho dyhagho added the major Breaking change label Aug 29, 2023
@github-actions
Copy link

Visit https://backpack.github.io/storybook-prs/2982 to see this build running in a browser.

@dyhagho dyhagho self-assigned this Aug 30, 2023
@github-actions
Copy link

Visit https://backpack.github.io/storybook-prs/2982 to see this build running in a browser.

@dyhagho dyhagho marked this pull request as ready for review August 30, 2023 08:24
@github-actions
Copy link

Visit https://backpack.github.io/storybook-prs/2982 to see this build running in a browser.

@github-actions
Copy link

Visit https://backpack.github.io/storybook-prs/2982 to see this build running in a browser.

Copy link
Member

@olliecurtis olliecurtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the contribution ❤️

@olliecurtis olliecurtis merged commit 7fed6ea into main Aug 31, 2023
9 checks passed
@olliecurtis olliecurtis deleted the CAPY-119 branch August 31, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major Breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants