Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Capitalize Effect #55

Merged
merged 6 commits into from
Apr 27, 2021
Merged

Capitalize Effect #55

merged 6 commits into from
Apr 27, 2021

Conversation

jsoucheiron
Copy link
Member

Fixes

  • Fix to ensure all Statement.Effect fields are always capitalized

oscarbc96
oscarbc96 approved these changes Apr 27, 2021
View reviewed changes
Copy link
Contributor

@oscarbc96 oscarbc96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀🚀

ocrawford555
ocrawford555 approved these changes Apr 27, 2021
View reviewed changes
Copy link
Contributor

@ocrawford555 ocrawford555 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Jordi!! 😄

@jsoucheiron jsoucheiron merged commit c5868a3 into master Apr 27, 2021
@jsoucheiron jsoucheiron deleted the HOTFIX-capitalize_effect branch April 27, 2021 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscarbc96 oscarbc96 oscarbc96 approved these changes

@ocrawford555 ocrawford555 ocrawford555 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jsoucheiron @oscarbc96 @ocrawford555