add semistrictbool for fixing booleans #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscarbc96
commented
Feb 23, 2022
pycfmodel/resolver.py
Outdated
| @@ -19,7 +20,7 @@ def _extended_bool(value) -> bool: | |||
|
|
|||
|
|
|||
| class _BooleanModel(BaseModel): | |||
| bool_value: bool | |||
| bool_value: SemiStrictBool | |||
There was a problem hiding this comment.
this is not strictly necessary, it can reveted
There was a problem hiding this comment.
Check 15863aa since got it reverted and test pass.
added 5 commits
February 24, 2022 08:53
w0rmr1d3r
previously approved these changes
Feb 24, 2022
pycfmodel/model/types.py
Outdated
| return value | ||
|
|
||
| if isinstance(value, str) and value.lower() in ("true", "false"): | ||
| return value == "true" |
There was a problem hiding this comment.
What about if value is "True" or "TRUE"? Do we need to have value.lower() == "true"?
There was a problem hiding this comment.
Made a proposal on how to solve this at df58525
@oscarbc96 can you check that possible solution as well?
Thank you both!
ocrawford555
approved these changes
Feb 24, 2022
w0rmr1d3r
approved these changes
Feb 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0.16.3 - [2022-02-24]
Fixes
resolveforbools that can bestrsuch as"true"or"false"or similar, by makingResolvableBoolto be resolvable toSemiStrictBool.Updates
CLOUDFORMATION_ACTIONS.