Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make turbolift ignore empty lines from repos.txt #47

Merged
merged 3 commits into from
May 14, 2021
Merged

Make turbolift ignore empty lines from repos.txt #47

merged 3 commits into from
May 14, 2021

Conversation

kevinrobayna
Copy link
Contributor

This PR fixes #46

@kevinrobayna kevinrobayna marked this pull request as ready for review May 14, 2021 07:57
sledigabel
sledigabel approved these changes May 14, 2021
View reviewed changes
Copy link
Contributor

@sledigabel sledigabel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ignores empty lines.
We could extend this to ignore lines with only whitespaces as well but that could be for another PR.

@sledigabel
Copy link
Contributor

Thank you for your contribution @kevinrobayna !

@sledigabel sledigabel merged commit cc4316b into Skyscanner:main May 14, 2021
@kevinrobayna kevinrobayna deleted the patch-1 branch May 14, 2021 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sledigabel sledigabel sledigabel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Turbolift can't start when there's an empty line in repos.txt
2 participants
@kevinrobayna @sledigabel