-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add git clone command #49
Conversation
Your suggestion makes a lot of sense and I don't have any objection for this to be the default behaviour. |
Argh I should have put this comment here. But yes, I agree with @sledigabel! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks fine to me if we’re just implementing the ‘back half’ of the feature. I’d suggest, though, doing the modifications to the clone
cobra command as well.
Agreed with @rnorth, let's add the whole thing into this PR rather than breaking it down into multiple PRs as we have agreed this will be the new default. |
@Macavirus how do you want to proceed? do you want to amend this PR and change the default behaviour of |
@sledigabel shall we discuss one of us picking this up some time? |
GMTA, I have a draft for this :-) publishing soon |
Merging this and will iterate from there. Thanks a lot for your contribution @Macavirus ! |
Partially addresses #48
This makes no actual changes to any commands, but adds the ability to call
Clone
function.As there is still some ambiguity around how we should address the actual
turbolift clone
command, I will address that in a followup PR.@sledigabel @rnorth would you prefer to preserve current behaviour in
clone.go
to fork by default? I think not forking by default is more user-friendly in general, but it sounds like the Skyscanner use case requires bulk forking.My suggestion would be to make the new Clone command default, and place
ForkAndClone
behind a different cobra command.