Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the spinner/color package #54

Merged
merged 1 commit into from
Jun 7, 2021
Merged

Conversation

lanwen
Copy link
Contributor

@lanwen lanwen commented Jun 7, 2021

I faced some issues running the current master in the Intellij IDEA terminal, which gives me a lot of ^WWWWWW in the output.

The latest spinner release seems fixed it. Current commit is the result of a
go get -u github.com/briandowns/spinner command

I faced some issues running the current master in the Intellij IDEA terminal, which gives me a lot of `^WWWWWW` in the output.

The latest spinner release seems fixed it. Current commit is the result of a
`go get -u github.com/briandowns/spinner` command
Copy link
Contributor

@sledigabel sledigabel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, bumps the version of spinner and color, the others are indirects

@sledigabel sledigabel merged commit 9183791 into Skyscanner:main Jun 7, 2021
@sledigabel
Copy link
Contributor

Thank you for your contribution @lanwen !

@lanwen lanwen deleted the upd branch June 7, 2021 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants