better catch exceptions #434
Conversation
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to d369a41 in 1 minute and 55 seconds
More details
- Looked at
160lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern/forge/agent.py:433
- Draft comment:
Thefail_taskmethod does not handle the case where the task or step status cannot be updated to 'failed'. This could lead to situations where task failures are not properly recorded. Consider adding error handling or logging to address this potential issue. - Reason this comment was not posted:
Confidence of 0% on close inspection, compared to threshold of 50%.
Workflow ID: wflow_sunf7NSg7cPERcuz
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
⌛ 1 day left in your free trial, upgrade for $20/seat/month or contact us.
skyvern/forge/agent.py
Outdated
| api_key=api_key, | ||
| close_browser_on_completion=close_browser_on_completion, | ||
| ) | ||
| try: |
There was a problem hiding this comment.
oops i didn't see your PR until now. I already fixed the StepTerminationError handling in this PR: https://github.com/Skyvern-AI/skyvern-cloud/commit/358f04754bda789ebcc280132a95df84a869da7d#diff-97d27efc4f9823539ec219d1cc210dd6a7bf7d4c5ef4b1f9a1dfe937eff5774e
skyvern/forge/agent.py
Outdated
| step_id=step.step_id, | ||
| ) | ||
| finally: | ||
| await self.send_task_response( |
There was a problem hiding this comment.
I don't think we should send_task_response again here since this is the exception handler for send_task_response already. we might get into an infinite loop
There was a problem hiding this comment.
Em. There must be something wrong wih the github diff. I didn't do send_task_response again in the FailedToSendWebhook..
skyvern/forge/agent.py
Outdated
| step_id=step.step_id, | ||
| ) | ||
| finally: | ||
| await self.send_task_response( |
There was a problem hiding this comment.
i think we should move this line to after line 412. it's very likely that the task is already in a timed_out or failed state. We might already have failed the task and sent a response to the webhook so we don't want to send webhook request again.
There was a problem hiding this comment.
this should be correct.
skyvern/forge/agent.py
Outdated
| if isinstance(e, SkyvernException): | ||
| failure_reason = f"unexpected SkyvernException({e.__class__.__name__})" | ||
|
|
||
| try: |
There was a problem hiding this comment.
let's make the try except logic simpler
There was a problem hiding this comment.
❌ Changes requested. Incremental review on 2132c18 in 2 minutes and 18 seconds
More details
- Looked at
140lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_KtS9o7tfpINb1J0z
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| ) | ||
| return step, detailed_output, None | ||
|
|
||
| async def fail_task(self, task: Task, step: Step | None, reason: str | None) -> None: |
There was a problem hiding this comment.
The PR description mentions introducing a retry mechanism, but the diff shows the removal of the retry mechanism from the fail_task method. This change could lead to issues in handling transient errors effectively. Please clarify or reconsider this change.
LawyZheng
force-pushed
the
better-catca-exceptions
branch
from
2132c18
to
2030f65
Compare
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 2030f65 in 3 minutes and 34 seconds
More details
- Looked at
47lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_207FFFxDpEJo3Gw0
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Summary:
This PR refactors exception handling, updates task status transitions, and adjusts the
fail_taskmethod by removing retry logic inskyvern/forge/agent.py.Key points:
skyvern/forge/agent.pyfail_taskmethod inskyvern/forge/agent.py, removing retry logicTaskStatustransitions inskyvern/forge/sdk/schemas/tasks.pyto includefailedfromqueuedGenerated with ❤️ by ellipsis.dev