Implementing Github Actions

[martin-key]

Implementing Github Actions

Summary

As I needed the Github actions working for slather and coveralls I have used #459 as a base to start debugging and to find the problem. I have sent an email to coveralls support and they have answered that for github actions they are not using the coveralls repo secret, but they are using the GITHUB_TOKEN env secret from github actions. I have implemented that change and also I have added some more useful env variables for the report generation.

Result

As a result the reports are working correctly using slather with github actions and coveralls.

References that I have used for the development:

• Add GitHub actions #459 (thanks @troyfontaine)
• https://github.com/marketplace/actions/coveralls-github-action
• https://docs.coveralls.io/api-reference

Additional info

• All the commits has been squashed
• PR may be merged with Squash and merge for clean description and reference to the PR.

[coveralls]

Coverage decreased (-0.3%) to 95.527% when pulling aab480b on martin-key:add-github-actions into dc89ab0 on SlatherOrg:master.

[ksuther]

Thanks for the PR! It'd be nice to get confirmation from someone else who has been waiting on this that everything works for them before I merge and make a release.

[brunohenriquesk1]

@ksuther I can confirm that everything works, our company is using Github actions and slather.

thanks @martin-key for implementing these changes!

[martin-key]

@ksuther I will do a few minor amendments and will post here when it is ready for merging.

[martin-key]

Ok, all the commits are correctly squashed and also I have improved the documentation so the correct branch appears in coveralls.

[ksuther]

Great, merging it and making a release. Thanks to everyone who helped on this :)

[ksuther]

One of the new tests failed in Travis. Not sure why it didn't show up in the PR though. Is this passing on your end?

https://travis-ci.org/github/SlatherOrg/slather/builds/747088844

  1) Slather::CoverageService::Coveralls#coveralls_coverage_data coverage_service is :github should return valid json for coveralls coverage data

     Failure/Error: expect(fixtures_project.send(:coveralls_coverage_data)).to be_json_eql("{\"service_job_id\":\"9182\",\"service_name\":\"github\",\"repo_token\":\"abc123\",\"service_pull_request\":\"1\",\"service_build_url\":\"https://github.com/Bruce/Wayne/actions/runs/1\",\"git\":{\"head\":{\"id\":\"ababa123\",\"author_name\":\"bwayne\",\"message\":\"hello\"},\"branch\":\"master\"}}").excluding("source_files")

     

       Expected equivalent JSON

       Diff:

       @@ -7,6 +7,7 @@

              "message": "hello"

            }

          },

       +  "repo_name": "",

          "repo_token": "abc123",

          "service_build_url": "https://github.com/Bruce/Wayne/actions/runs/1",

          "service_job_id": "9182",

       

     # ./spec/slather/coverage_service/coveralls_spec.rb:164:in `block (4 levels) in <top (required)>'

Finished in 52.27 seconds (files took 1.02 seconds to load)

180 examples, 1 failure

Failed examples:

rspec ./spec/slather/coverage_service/coveralls_spec.rb:158 # Slather::CoverageService::Coveralls#coveralls_coverage_data coverage_service is :github should return valid json for coveralls coverage data

[afinetooth]

LGTM from coveralls.