Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: On Mac, create links to the lib and Frameworks folders so the executables find the libs from Slicer #212

Merged
merged 1 commit into from Feb 7, 2013

Conversation

adrienkaiser
Copy link
Contributor

Compare View from last revision to new revision:
http://github.com/NIRALUser/DTIAtlasBuilder/compare/cb8f0f7...dd213c9

@ghost ghost assigned jcfr Feb 7, 2013
@jcfr
Copy link
Member

jcfr commented Feb 7, 2013

Instead of providing a script named "AppleCreateLinkLibs.sh", what about the following approach:

As a side note, I also created an issue named "Possibility to run a post install script" in the slicer bug tracker. See http://www.na-mic.org/Bug/view.php?id=2920

@fbudin69500
Copy link
Member

Hello JC,

We did add symlinks, but since we were not 100% sure that it would work, we also embedded a script to create those links as a safety measure. Hopefully we will not need to run the script, but since we need those extensions to run before this weekend, we wanted to play it safe, and it was easy to just add one small script just in case.

Sincerely,

Francois

@fbudin69500
Copy link
Member

More precisely, we included the symlinks in the source directory, and we are copying them in the package when the install is done.

@jcfr
Copy link
Member

jcfr commented Feb 7, 2013

Sounds good. Thanks for clarifying.

On Thu, Feb 7, 2013 at 4:43 PM, Francois Budin notifications@github.comwrote:

More precisely, we included the symlinks in the source directory, and we
are copying them in the package when the install is done.


Reply to this email directly or view it on GitHubhttps://github.com//pull/212#issuecomment-13261540.

+1 919 869 8849

jcfr added a commit that referenced this pull request Feb 7, 2013
BUG: On Mac, create links to the lib and Frameworks folders so the executables find the libs from Slicer
@jcfr jcfr merged commit a6bf39b into Slicer:master Feb 7, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants