Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove remaining TCL build options #4865

Closed
hjmjohnson opened this issue Apr 19, 2020 · 1 comment · Fixed by #4867
Closed

Remove remaining TCL build options #4865

hjmjohnson opened this issue Apr 19, 2020 · 1 comment · Fixed by #4867
Labels
Type: Enhancement Improvement to functionality
Milestone
Slicer 4.13

Comments

@hjmjohnson
Copy link
Member

Is your feature request related to a problem? Please describe.

No problem, reduce development burden by removing code and build options that have minimal benefit to the Slicer community.

Describe the solution you'd like

Remove all code reference by "Slicer_USE_PYTHONQT_WITH_TCL" variable.

Describe alternatives you've considered

--- Perhaps this is really more important than it appears in the code base. Then turn it on by default, and ensure it is tested.

Additional context

Finding ways to minimize developer burden.
@hjmjohnson hjmjohnson added the Type: Enhancement Improvement to functionality label Apr 19, 2020
@jamesobutler
Copy link
Contributor

Here is a link to a past discussion as it relates to TCL and EMSegment
https://discourse.slicer.org/t/should-we-do-something-about-em-segmenter/4382

hjmjohnson added a commit to hjmjohnson/Slicer that referenced this issue Apr 19, 2020
@hjmjohnson
ENH: Remove unsupported/deprecated tcl functionality
9e18874 
See:
https://discourse.slicer.org/t/should-we-do-something-about-em-segmenter/4382/5

Resolves Slicer#4865
@hjmjohnson hjmjohnson mentioned this issue Apr 19, 2020
Merged
hjmjohnson added a commit to hjmjohnson/Slicer that referenced this issue Apr 19, 2020
@hjmjohnson
ENH: Remove unsupported/deprecated tcl functionality
1e7aebf 
See:
https://discourse.slicer.org/t/should-we-do-something-about-em-segmenter/4382/5

Resolves Slicer#4865
@sjh26 sjh26 added this to the Slicer 4.11.0 milestone Apr 21, 2020
pieper pushed a commit that referenced this issue Apr 21, 2020
@hjmjohnson
ENH: Remove unsupported/deprecated tcl functionality (#4867)
9a9c2b1 
See:
https://discourse.slicer.org/t/should-we-do-something-about-em-segmenter/4382/5

Resolves #4865
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Enhancement Improvement to functionality
Milestone
Slicer 4.13
Development

Successfully merging a pull request may close this issue.

ENH: Remove unsupported/deprecated tcl functionality hjmjohnson/Slicer
3 participants
@hjmjohnson @jamesobutler @sjh26