Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thick Slab Reconstruction corner-annotation not visible by default in Slice viewer #7092

Closed
jcfr opened this issue Jul 14, 2023 · 0 comments · Fixed by #7177
Closed

Thick Slab Reconstruction corner-annotation not visible by default in Slice viewer #7092

jcfr opened this issue Jul 14, 2023 · 0 comments · Fixed by #7177
Assignees
@jcfr
Labels
Type: Enhancement Improvement to functionality
Milestone
Slicer 5.3

Comments

@jcfr
Copy link
Member

jcfr commented Jul 14, 2023 •
edited

Text below adapted from comment originally posted in #7021 (comment)

Is your feature request related to a problem? Please describe.

Following the integration of #7021, it is now possible to enable thick slab reconstruction from the Slice Controller.

The problem is that after enabling it, it is not shown by default in the top-right corner.

This happen because the corresponding corner is not active in the Data Probe module:

Describe the solution you'd like

There are few paths forward to address this:

  1. Change the default value for the top-right corner
  2. Automatically toggle top-right corner to active
    1. And leave it enabled even after the slab reconstruction is toggled back off (should a confirmation dialog be displayed?)
    2. Or have a tri-state like settings
  3. Update display logic to display the corner if the corner is active or if the associated function vtkMRMLSliceNode::GetSlabReconstructionEnabled() return True

It seems that moving forward with either 1 or 2.i is sensible.

Previous discussions

From @lassoan:

The Data Probe module's corner annotation handling is so bad that I don't mind whatever option is chosen. What we really need is a proper displayable manager that can display various dynamic text (orientation, slice thickness, DICOM fields, etc.) and content from any vtkMRMLTextNode.

Originally posted by @lassoan in #7021 (comment)

From @jamesobutler:

1 or 2.i is fine with me.

Our group doesn't use corner text annotations at all as our volume names have generally been long and we didn't like it getting in the way of actually viewing the image data.

Originally posted by @jamesobutler in #7021 (comment)

Describe alternatives you've considered

Update documentation without implementing any changes.

Additional context
@jcfr jcfr added the Type: Enhancement Improvement to functionality label Jul 14, 2023
@jcfr jcfr added this to the Slicer 5.3 milestone Jul 14, 2023
@jcfr jcfr self-assigned this Jul 27, 2023
@jcfr jcfr added the Status: In Progress Person who the issue is assigned to currently works on this label Aug 17, 2023
This was referenced Aug 17, 2023
Merged
Merged
Merged
jcfr added a commit to jcfr/Slicer that referenced this issue Aug 17, 2023
@jcfr
ENH: Ensure slab reconstruction thickness is visible in slice view co…
0939fa9 
…rner

Ensure that the visibility of the corner annotation displaying the
thickness of the slab reconstruction is automatically toggled without
requiring the user to explicitly do so in the DataProbe module.

Fixes Slicer#7092
@jcfr jcfr mentioned this issue Aug 17, 2023
Merged
jcfr added a commit to jcfr/Slicer that referenced this issue Aug 18, 2023
@jcfr
ENH: Ensure slab reconstruction thickness is visible in slice view co…
7f4d710 
…rner

Ensure that the visibility of the corner annotation displaying the
thickness of the slab reconstruction is automatically toggled without
requiring the user to explicitly do so in the DataProbe module.

Fixes Slicer#7092
jcfr added a commit to jcfr/Slicer that referenced this issue Aug 18, 2023
@jcfr
ENH: Ensure slab reconstruction thickness is visible in slice view co…
fcba09a 
…rner

Ensure that the visibility of the corner annotation displaying the
thickness is automatically toggled without requiring the user to
explicitly do so in the DataProbe module.

If the visibility of the corner annotation was enabled by "forcing", it
will not be saved in the settings.

Fixes Slicer#7092
jcfr added a commit that referenced this issue Aug 18, 2023
@jcfr
ENH: Ensure slab reconstruction thickness is visible in slice view co…
3ce7b54 
…rner

Ensure that the visibility of the corner annotation displaying the
thickness is automatically toggled without requiring the user to
explicitly do so in the DataProbe module.

If the visibility of the corner annotation was enabled by "forcing", it
will not be saved in the settings.

Fixes #7092
@jcfr jcfr removed the Status: In Progress Person who the issue is assigned to currently works on this label Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcfr jcfr

Labels
Type: Enhancement Improvement to functionality
Milestone
Slicer 5.3
Development

Successfully merging a pull request may close this issue.

ENH: Ensure slab reconstruction thickness is visible in slice view corner jcfr/Slicer
1 participant
@jcfr