ENH: Support restoring SliceViewAnnotations enabled state #7176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
jcfr
force-pushed
the
support-restoring-slice-view-annotations-enabled-state
branch
from
ff4bf23
to
4a149d2
Compare
CheckListStatus: Updated topic works as expected
|
|
Slice view annotations is a mess. It was a quick prototype that got integrated to have this important feature in Slicer, but the design is really fragile and limited. We would need to rebuild it from scratch, using proper MRML-based design and flexibility and extensibility in mind, as overlay on image corners is very important space for displaying information. |
|
Many viewers also use these as UI controls/widgets too (e.g. control reslice rotation or window/level tools by clicking on the corresponding corner annotation can be logical and discoverable). |
jcfr
force-pushed
the
support-restoring-slice-view-annotations-enabled-state
branch
from
4a149d2
to
d11a1c6
Compare
CheckListStatus: Updated topic works as expected ✅
|
Also simplify setting of checkbox state in SliceViewAnnotations
jcfr
force-pushed
the
support-restoring-slice-view-annotations-enabled-state
branch
from
d11a1c6
to
6822a6f
Compare
jcfr
deleted the
support-restoring-slice-view-annotations-enabled-state
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also simplify setting of checkbox state in SliceViewAnnotations
This pull request was created while working on this issue: