Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sequence proxy node not updated after reopening scene with stored sequence #7440

Closed
che85 opened this issue Dec 1, 2023 · 1 comment · Fixed by #7441
Closed

Sequence proxy node not updated after reopening scene with stored sequence #7440

che85 opened this issue Dec 1, 2023 · 1 comment · Fixed by #7441
Assignees
@lassoan
Labels
Type: Bug Something isn't working correctly
Milestone
Slicer 5.7

Comments

@che85
Copy link
Contributor

che85 commented Dec 1, 2023

Summary

@lassoan

When loading a scene that includes a sequence in Slicer 5.6.0 (I only tested with volume sequence), the proxy node of the sequence node is not updated anymore when playing the sequence.

Steps to reproduce

  1. Download from SampleData: CT Cardio Sequence
  2. Save the current scene to .mrb file
  3. close scene
  4. reopen .mrb file
  5. play sequence --> proxy node is not updated

Environment

  • Slicer version: Slicer-5.6.0 stable
  • Operating system: tested on Windows and Mac
@lassoan
Copy link
Contributor

lassoan commented Dec 1, 2023

Thanks for reporting, I'll investigate.

@lassoan lassoan self-assigned this Dec 1, 2023
@lassoan lassoan added this to the Slicer 5.7 milestone Dec 1, 2023
@jcfr jcfr added the Type: Bug Something isn't working correctly label Dec 1, 2023
lassoan added a commit to lassoan/Slicer that referenced this issue Dec 3, 2023
@lassoan
BUG: Fix loading of sequence nodes
85d1682 
When a sequence was saved into a scene and then that scene was loaded then browsing did not work.
The problem was caused by a typo that set missingItemMode to invalid and thereby disabling copying of sequence content into the proxy node.

Fixed the typo, made setting of missingItemMode more robust (if invalid string is found then the mode is not changed just a warning is logged), and added automated tests to capture similar errors in the future.

fixes Slicer#7440
lassoan added a commit to lassoan/Slicer that referenced this issue Dec 3, 2023
@lassoan
BUG: Fix loading of sequence nodes
ead4440 
When a sequence was saved into a scene and then that scene was loaded then browsing did not work.
The problem was caused by a typo that set missingItemMode to invalid and thereby disabling copying of sequence content into the proxy node.

Fixed the typo, made setting of missingItemMode more robust (if invalid string is found then the mode is not changed just a warning is logged), and added automated tests to capture similar errors in the future.

fixes Slicer#7440
@lassoan lassoan mentioned this issue Dec 3, 2023
Merged
lassoan added a commit to lassoan/Slicer that referenced this issue Dec 3, 2023
@lassoan
BUG: Fix loading of sequence nodes
a9375be 
When a sequence was saved into a scene and then that scene was loaded then browsing did not work.
The problem was caused by a typo that set missingItemMode to invalid and thereby disabling copying of sequence content into the proxy node.

Fixed the typo, made setting of missingItemMode more robust (if invalid string is found then the mode is not changed just a warning is logged), and added automated tests to capture similar errors in the future.

fixes Slicer#7440
lassoan added a commit to lassoan/Slicer that referenced this issue Dec 3, 2023
@lassoan
BUG: Fix loading of sequence nodes
fb56b4e 
When a sequence was saved into a scene and then that scene was loaded then browsing did not work.
The problem was caused by a typo that set missingItemMode to invalid and thereby disabling copying of sequence content into the proxy node.

Fixed the typo, made setting of missingItemMode more robust (if invalid string is found then the mode is not changed just a warning is logged), and added automated tests to capture similar errors in the future.

fixes Slicer#7440
lassoan added a commit that referenced this issue Dec 4, 2023
@lassoan
BUG: Fix loading of sequence nodes
140d58a 
When a sequence was saved into a scene and then that scene was loaded then browsing did not work.
The problem was caused by a typo that set missingItemMode to invalid and thereby disabling copying of sequence content into the proxy node.

Fixed the typo, made setting of missingItemMode more robust (if invalid string is found then the mode is not changed just a warning is logged), and added automated tests to capture similar errors in the future.

fixes #7440
jcfr pushed a commit to jcfr/Slicer that referenced this issue Dec 11, 2023
@lassoan @jcfr
BUG: Fix loading of sequence nodes
6b22c8d 
When a sequence was saved into a scene and then that scene was loaded then browsing did not work.
The problem was caused by a typo that set missingItemMode to invalid and thereby disabling copying of sequence content into the proxy node.

Fixed the typo, made setting of missingItemMode more robust (if invalid string is found then the mode is not changed just a warning is logged), and added automated tests to capture similar errors in the future.

fixes Slicer#7440

(cherry picked from commit 140d58a)
@jcfr jcfr mentioned this issue Dec 11, 2023
Merged
jcfr pushed a commit that referenced this issue Dec 11, 2023
@lassoan @jcfr
BUG: Fix loading of sequence nodes
48e0b02 
When a sequence was saved into a scene and then that scene was loaded then browsing did not work.
The problem was caused by a typo that set missingItemMode to invalid and thereby disabling copying of sequence content into the proxy node.

Fixed the typo, made setting of missingItemMode more robust (if invalid string is found then the mode is not changed just a warning is logged), and added automated tests to capture similar errors in the future.

fixes #7440

(cherry picked from commit 140d58a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lassoan lassoan

Labels
Type: Bug Something isn't working correctly
Milestone
Slicer 5.7
Development

Successfully merging a pull request may close this issue.

BUG: Fix loading of sequence nodes lassoan/Slicer
3 participants
@jcfr @lassoan @che85