BUG: Fix loading of sequence nodes #7441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lassoan
force-pushed
the
fix-sequence-loading
branch
from
ead4440
to
a9375be
Compare
When a sequence was saved into a scene and then that scene was loaded then browsing did not work. The problem was caused by a typo that set missingItemMode to invalid and thereby disabling copying of sequence content into the proxy node. Fixed the typo, made setting of missingItemMode more robust (if invalid string is found then the mode is not changed just a warning is logged), and added automated tests to capture similar errors in the future. fixes Slicer#7440
lassoan
force-pushed
the
fix-sequence-loading
branch
from
a9375be
to
fb56b4e
Compare
jcfr
added
the
backport:5.x
This was referenced Dec 11, 2023
jcfr
removed
the
backport:5.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a sequence was saved into a scene and then that scene was loaded then browsing did not work. The problem was caused by a typo that set missingItemMode to invalid and thereby disabling copying of sequence content into the proxy node.
Fixed the typo, made setting of missingItemMode more robust (if invalid string is found then the mode is not changed just a warning is logged), and added automated tests to capture similar errors in the future.
fixes #7440