ENH: Use ManifestDPIAware to improve the look of the Windows installer #4816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcfr
requested changes
Apr 15, 2020
There was a problem hiding this comment.
Thanks for the patch.
After addressing few nitpicks, it will be good for integration.
Consider splitting into two commits with first one having the following title/message:
COMP: Update SlicerCPack to set CPACK_NSIS_DEFINES as a string
The variable value must be as a single string to avoid inserting semicolons
into the script.
The variable value must be as a single string to avoid inserting semicolons into the script.
Adds "ManifestDPIAware true" to CPACK_NSIS_DEFINES.
sjh26
force-pushed
the
fix-blurry-windows-installer
branch
from
88df466
to
7e55f0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4279
Adds "ManifestDPIAware true" to CPACK_NSIS_DEFINES. The variable value
must be as a single string to avoid inserting semicolons into the scripts
Before:
After:
"Before" installer
"After" installer