COMP: Improve "CI" GitHub Action workflow uploading package as artifact #6053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit copies the package to GITHUB_WORKSPACE instead of RUNNER_TEMP. This is required to workaround issue discussed in actions/runner#965 (Incorrect context paths in container) It also adds a step for uploading the generated Slicer package as an artifact with a retention time of 1 day.
|
Is there a way to download the created install package? We could even build a SlicerNotebook image with it. Testers could run that in the web browser using https://mybinder.org/, without the need to download and install the package on a Linux box. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit copies the package to
GITHUB_WORKSPACEinstead ofRUNNER_TEMP. Thisis required to workaround issue discussed in actions/runner#965 (Incorrect context
paths in container)
It also adds a step for uploading the generated Slicer package as an
artifact with a retention time of 1 day.