Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMP: Fix "ci" GitHub workflow ensuring Slicer package is uploaded #7249

Conversation

jcfr
Copy link
Member

@jcfr jcfr commented Sep 27, 2023

Set the step id to slicer-build to ensure the use of ${{ steps.slicer-build.outputs.package }} in the Upload Slicer package step effectively lookup the package.

Follow up of these pull requests:

Also fix the following warning:

The set-output command is deprecated and will be disabled soon.
Please upgrade to using Environment Files.
For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Temporarily including the following patch to the pull-request allowed to test the changes:

diff --git a/.github/actions/slicer-build/entrypoint.sh b/.github/actions/slicer-build/entrypoint.sh
index 2caf49c7f02..50e709c8579 100755
--- a/.github/actions/slicer-build/entrypoint.sh
+++ b/.github/actions/slicer-build/entrypoint.sh
@@ -6,13 +6,16 @@ set -o
 
 cp -r $GITHUB_WORKSPACE /usr/src/Slicer
 
-/usr/src/Slicer-build/BuildSlicer.sh
-package_filepath=$(head -n1 /usr/src/Slicer-build/Slicer-build/PACKAGE_FILE.txt)
+#/usr/src/Slicer-build/BuildSlicer.sh
+#package_filepath=$(head -n1 /usr/src/Slicer-build/Slicer-build/PACKAGE_FILE.txt)
+package_filepath=/usr/src/Slicer-build/Slicer-build/Slicer-5.5.0-2023-09-26-linux-amd64.tar.gz
+echo "Dummy package" > $package_filepath
 echo "package_filepath [${package_filepath}]"
 
 mv ${package_filepath} $GITHUB_WORKSPACE/
 
 package=$(basename $package_filepath)
 echo "package [${package}]"
+echo "GITHUB_OUTPUT [$GITHUB_OUTPUT]"
 
 echo "package=$package" >> $GITHUB_OUTPUT

and confirm it was working as expected:

image image

@jcfr jcfr force-pushed the update-slicer-build-workflow-ensuring-package-is-uploaded branch 2 times, most recently from bb1c944 to 1e5745f Compare September 27, 2023 18:50
Fix the following warning:

  The `set-output` command is deprecated and will be disabled soon.
  Please upgrade to using Environment Files.
  For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
@jcfr jcfr force-pushed the update-slicer-build-workflow-ensuring-package-is-uploaded branch 2 times, most recently from fe17c6e to 193e74f Compare September 27, 2023 19:26
@jcfr jcfr enabled auto-merge (rebase) September 27, 2023 19:26
Copy link
Contributor

@sjh26 sjh26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jcfr jcfr merged commit c410ead into Slicer:main Sep 27, 2023
5 checks passed
@jcfr jcfr deleted the update-slicer-build-workflow-ensuring-package-is-uploaded branch September 27, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants