BUG: Fix scripted module template observer warning #6720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whenever the user leaves the template module, the parameter node observers are removed. If the module is entering after that, setParameterNode() will attempt to remove the observer again, and throw a warning message. Fixed by checking if the observer exists before removing in setParameterNode(). See: https://discourse.slicer.org/t/warning-of-observer-from-scripted-module-in-slicer-5-0-3/
NicerNewerCar
added a commit
to NicerNewerCar/SlicerAutoscoperM
that referenced
this pull request
Jul 6, 2023
* Bug was initally fixed in the scripted module template in [PR #6720](Slicer/Slicer#6720) from Slicer core. * This module was created in 2021 while the above PR was integrated in late 2022
NicerNewerCar
added a commit
to NicerNewerCar/SlicerAutoscoperM
that referenced
this pull request
Jul 6, 2023
* Bug was initially fixed in the scripted module template in [PR #6720](Slicer/Slicer#6720) from Slicer core. * This module was created in 2021 while the above PR was integrated in late 2022
jcfr
pushed a commit
to BrownBiomechanics/SlicerAutoscoperM
that referenced
this pull request
Jul 28, 2023
* Bug was initially fixed in the scripted module template in [PR #6720](Slicer/Slicer#6720) from Slicer core. * This module was created in 2021 while the above PR was integrated in late 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever the user leaves the template module, the parameter node observers are removed. If the module is entering after that, setParameterNode() will attempt to remove the observer again, and throw a warning message.
Fixed by checking if the observer exists before removing in setParameterNode().
See: https://discourse.slicer.org/t/warning-of-observer-from-scripted-module-in-slicer-5-0-3/