-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add vtkITKGrowCut filter #6946
Conversation
20bebdd
to
2b54dfe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Sunderlandkyl this works very well. I've found only one small issue that would need to be fixed before integrating: seed locality does not have an effect unless you cancel and re-initialize.
Example:
Default:
Setting Seed locality to 10 has no effect:
After Cancel and Initialize it provides correct result:
It would probably need to be fixed in ITK (or at least file a bug report in ITK) to invalidate the internal computed distances if the distance penalty value is modified.
But as an immediate workaround in Slicer (to enable merging without waiting for the fix in ITK) could be to cancel and initialize the filter.
@Sunderlandkyl the number of open issues for the new stable release (https://github.com/Slicer/Slicer/milestone/6) is decreasing quite rapidly, so it seems that we can cut the new release soon. It would be nice if you could fix the small seed locality update issue (see above) by early next week because then this PR could be included in this release. Thanks in advance! |
ae9116e
to
f85eea6
Compare
Thanks for the review Andras! |
This commit adds a new VTK filter vtkITKGrowCut, which uses the itk::FastGrowCut implementation. The new filter is used in the "Grow from seeds" segment editor effect. SegmentationsModuleTest2 now includes a Grow from seeds test. Re Slicer#6936
f85eea6
to
03eeef0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I've added an ITK bug report (InsightSoftwareConsortium/ITKGrowCut#18)
This commit adds a new VTK filter vtkITKGrowCut, which uses the itk::FastGrowCut implementation.
The new filter is used in the "Grow from seeds" segment editor effect.
SegmentationsModuleTest2 now includes a Grow from seeds test.