Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add vtkITKGrowCut filter #6946

Merged
merged 2 commits into from
Jul 12, 2023
Merged

Conversation

Sunderlandkyl
Copy link
Member

This commit adds a new VTK filter vtkITKGrowCut, which uses the itk::FastGrowCut implementation.
The new filter is used in the "Grow from seeds" segment editor effect.
SegmentationsModuleTest2 now includes a Grow from seeds test.

@Sunderlandkyl Sunderlandkyl force-pushed the itk_grow_cut branch 2 times, most recently from 20bebdd to 2b54dfe Compare April 18, 2023 15:48
@jcfr jcfr linked an issue Jun 20, 2023 that may be closed by this pull request
Copy link
Contributor

@lassoan lassoan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Sunderlandkyl this works very well. I've found only one small issue that would need to be fixed before integrating: seed locality does not have an effect unless you cancel and re-initialize.

Example:

Default:

image

Setting Seed locality to 10 has no effect:

image

After Cancel and Initialize it provides correct result:

image

It would probably need to be fixed in ITK (or at least file a bug report in ITK) to invalidate the internal computed distances if the distance penalty value is modified.

But as an immediate workaround in Slicer (to enable merging without waiting for the fix in ITK) could be to cancel and initialize the filter.

@lassoan
Copy link
Contributor

lassoan commented Jul 11, 2023

@Sunderlandkyl the number of open issues for the new stable release (https://github.com/Slicer/Slicer/milestone/6) is decreasing quite rapidly, so it seems that we can cut the new release soon. It would be nice if you could fix the small seed locality update issue (see above) by early next week because then this PR could be included in this release. Thanks in advance!

@lassoan lassoan added this to the Slicer 5.3 milestone Jul 12, 2023
@Sunderlandkyl Sunderlandkyl force-pushed the itk_grow_cut branch 2 times, most recently from ae9116e to f85eea6 Compare July 12, 2023 15:41
@Sunderlandkyl
Copy link
Member Author

Thanks for the review Andras!
I've added a Reset() call when the distance penalty is changed.

This commit adds a new VTK filter vtkITKGrowCut, which uses the itk::FastGrowCut implementation.
The new filter is used in the "Grow from seeds" segment editor effect.
SegmentationsModuleTest2 now includes a Grow from seeds test.

Re Slicer#6936
Copy link
Contributor

@lassoan lassoan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I've added an ITK bug report (InsightSoftwareConsortium/ITKGrowCut#18)

@lassoan lassoan merged commit fe648e3 into Slicer:main Jul 12, 2023
5 checks passed
@Sunderlandkyl Sunderlandkyl deleted the itk_grow_cut branch July 12, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Switch to ITK's grow from seeds algorithm implementation
2 participants