BUG: Update VTK to remove unnecessary messages in vtkTransformPolyDataFilter #7227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aFilter
vtkTransformPolyDataFilter is often used in pipelines where it is
completely valid to have empty input.
For example, when slicing through a mesh with a plane, the output may be
empty if the plane does not happen to intersect any part of the mesh.
Logging an error pollutes the error log and if performed too frequently
then it may slow down an application.
List of VTK changes:
$ git shortlog b261e0c1b..b142c0d08 --no-merges
Andras Lasso (1):
[Backport] Remove unnecessary "No input data" error message in vtkTransformPolyDataFilter
Co-authored-by: Andras Lasso <lasso@queensu.ca>
|
Local testing confirmed that the issue is resolved ✅ |
lassoan
added
the
backport:5.x
|
Thank you. I've labelled this as need to be backported to Slicer-5.4.1. |
jcfr
removed
the
backport:5.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vtkTransformPolyDataFilteris often used in pipelines where it is completely valid to have empty input.For example, when slicing through a mesh with a plane, the output may be empty if the plane does not happen to intersect any part of the mesh. Logging an error pollutes the error log and if performed too frequently then it may slow down an application.
List of VTK changes: