Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Make more strings translatable #7243

Merged
merged 1 commit into from Sep 26, 2023
Merged

Conversation

lassoan
Copy link
Contributor

@lassoan lassoan commented Sep 26, 2023

Marked strings that were found to be non-translatable in Slicer/SlicerLanguagePacks#41


For reference, list of updated modules:

  • Models
  • VolumeRendering
  • CropVolumeSequence
  • DMRIInstall
  • Endoscopy
  • ImportItkSnapLabel
  • SampleData
  • ScreenCapture
  • SegmentEditor
  • SelfTests
  • VectorToScalarVolume
  • Templates

List of modules added by @jcfr while working on compiling the Slicer 5.6 release notes.

@lassoan lassoan added the Domain: i18n Internationalization (language translation) label Sep 26, 2023
@lassoan lassoan added this to the Slicer 5.5 milestone Sep 26, 2023
@lassoan lassoan self-assigned this Sep 26, 2023
@lassoan lassoan force-pushed the translation-fixes branch 2 times, most recently from de2011f to cd0839c Compare September 26, 2023 17:10
@lassoan lassoan force-pushed the translation-fixes branch 2 times, most recently from 1324108 to 2353d08 Compare September 26, 2023 18:14
jcfr
jcfr previously approved these changes Sep 26, 2023
Marked strings that were found to be non-translatable in Slicer/SlicerLanguagePacks#41
@lassoan
Copy link
Contributor Author

lassoan commented Sep 26, 2023

Thanks for the review @jcfr.

@mhdiop I'll merge it now to allow adding the new translatable strings to weblate, but if you find anything that I've missed then please submit a pull request.

@lassoan lassoan merged commit d3f49ed into Slicer:main Sep 26, 2023
5 checks passed
@lassoan lassoan deleted the translation-fixes branch September 26, 2023 20:53
@jcfr jcfr mentioned this pull request Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Domain: i18n Internationalization (language translation)
Development

Successfully merging this pull request may close these issues.

None yet

2 participants